There are two sets of permissions for this module.

The first set is for the content/node type (see first attachement).
The second is for the module itself (see second attachment).

It appears that some of the permissions appear in both sets, which may be confusing for users and may interfere with proper functionality of the module. I would suggest removing the content type permissions in favor of grouping all permissions together in one place for this module.

CommentFileSizeAuthor
Screen shot 2012-02-27 at 10.51.35 AM.png49.91 KBmattbk
Screen shot 2012-02-27 at 10.51.12 AM.png33.06 KBmattbk

Comments

Homotechsual’s picture

Homotechsual commented

I disagree, modular permissions which allow fine-grained control over who can do what make this module powerful and useful. Start dumbing down it's permissions because some users may find them confusing and you risk turning a powerful module into a useless one.

jeremy’s picture

jeremy commented
Status: Active » Fixed

@mattbk, nice catch, thanks. Drupal 7 core now adds per-content-type permissions automatically:
http://api.drupal.org/api/drupal/modules!node!node.module/function/node_...

I've removed the support module's custom implementation, favoring instead those provided by node_list_permissions(). I added an update handler that automatically converts the old permissions to the new. 'create tickets' becomes 'create support_ticket content', 'delete any ticket' becomes 'delete any support_ticket content', 'delete own tickets' becomes 'delete own support_ticket content', 'edit any ticket' becomes 'edit any support_ticket content', and 'edit own tickets' becomes 'edit own support_ticket content'.
http://drupalcode.org/project/support.git/commit/ba17219

@MJCO, no control is lost through this change, there were indeed duplicate permissions defined (only half of which were actually respected, clearly confusing).

Homotechsual’s picture

Homotechsual commented

Good to know,

Thanks very much for the clarification.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.