[Needs tests] Backport from D7 to use Google maps API V3 for D6 6.x-2.x-dev

This is an equivalent patch code for D7 to 818638 #120.
http://drupal.org/node/818638#comment-5593160

Many thanks for your hard work! This is an update that the GMap module sorely needs!

One small suggestion that came to mind: in your patch, js/marker.js still has calls to a few v2 API methods:

openInfoWindow() [line 93]
openInfoWindowHtml() [line 111]
openInfoWindowTabsHtml() [line 122]

Since this a patch for GMap API v.3 compatibility, would it make sense to re-implement these via instantiations of google.maps.InfoWindow()?

Sorry I'm kind of a noob, how exactly do you use this patch? Where do I put it? I am assuming I need this patch to get the maps to display, because they are no longer displaying using the V3 Google Maps API.

Ok, you can use the zip ball instead of applying the patch.

Download the zip ball from the following url (directly link).
https://github.com/haiiro-shimeji/gmap/zipball/7.x-1.x-gv3

EDIT: zip archive is available from the link written in the top of this thread.

Unzip this archive, then you get a directory named "haiiro-shimeji-gmap-*".
This is the patched gmap module (full files).
Rename this directory to "gmap", and move this to the modues/ directory in drupal home.

@haiiro.shimeji

I had tghe module under sites/all/modules. I movet it to the drupal root/modules and it worked.

Thanks a lot!!

I can approve #5, works for me!

Hello, any updates for Drupal 6 and the Google API V3.
Our sites are getting old and tired, We depend on Drupal community to keep our Free Organisations sites alive.
Helping people all over the world.

It is just too costly to upgrade and redo a site when you only need a few modules to upgrade.

Please make this module compatible with Drupal 6 and Google API V3.
Thanks you.

I had a problem on gmap_taxonomy.info but the patch works well. TY

patching file gmap_taxonomy.info
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file gmap_taxonomy.info.rej

I've installed files from zip in #8, and I get the following error in the Gmap admin settings page:

Notice: Use of undefined constant FILE_DOWNLOADS_PUBLIC - assumed 'FILE_DOWNLOADS_PUBLIC' in gmap_admin_settings() (line 20 of /var/www/my-site.it/sites/all/modules/contrib/gmap/gmap_settings_ui.inc).

Despite the error, all works fine

Thank you

UPDATE:
Applying the suggestion in #17 the error disappear

Downloaded the dev release and added the patch in #5 and the edit in #17. Also had the "hunk 1" failure, but I think that's probably not a problem.

Most of the functionality seems to work, except I don't get a gmap location picker. I'm using "Location CCK" as opposed to "node location". Is anyone getting the location picker with this version/patch? [EDIT: got that working-- a configuration issue.]

Also, any ideas on how to enable controls like street view and mobile location? I'm willing to put some work into getting this all going, but I'm not particularly familiar with the module.

Hi adraskoy,

I have the same issue with the marker not showing, could you share what you did to get it working?
I'm really a noob on this.

Thx in advance

Thanks for your testing.

@Xomby
I wonder User location module is not supported for D7 according to http://drupal.org/project/location #Important section.
Actually nothing is displayed in /location/users despite of my setting..


@macrocosm
It seems popup bubble is working..
Have you setup the views setting? Choose edit "location table" in admin/structure/views, click Gmap setting in "Format",
and check "Display a tooltip when hovering over markers" in the setting dialog.

About taxonomy marker, I don't know how to use it.. Can't it set up the original marker??

Pardon my ignorance, but I got the new gmap moved over and now I see a map of the US, it's not zooming into street level. Did I miss something?

You can see at http://bluebonnetcountrygc.com/ready-to-play/location that it should be zoomed into the course location based upon the Location Module but it's not working right.

Thanks,
Danny

@lgmanchego
This patch have no change for database.
Remove the patched module and put the old one, I think your site will be restored safely.

What does "crashed" mean? No page is displayed in your browser?
If that's the case, change display_errors parameter to "On" in the php.ini, please tell me the error messages.

The map is using the Location module on the page to show the location of the course on the map. I can physically zoom into the map, but there is no marker and it's not going to the course location. Sorry that I didn't clarify.

EDIT: OK, that worked for it zooming in to the correct level, but the marker isn't showing. What am I missing for that to come back?

Danny

I believe it's being input via the Node location, because on the content page I add the location to it in the Location area at the bottom. The map now zooms into the actual location correctly, it's just not showing a marker pin at the address location on the zoomed in map.

Thanks again!

@haiiro.shimeji

It appears your changes do not yet work with the location field, I get the same as the others, no markers appear.

Dear all,

I am using the form API to build new forms. I need to include a google map in the form and place some markers based on the position of the users.

I see that a lot of work has been done on google map api. However, I am not able to understand how to use it. If anyone can provide simple (but detailed) examples explaining how to use this api, it would be extremely helpful. I am at loss of how to use the immense module, without a help guide.

Thanks,
Ashvin

@haiiro.shimeji, apply to be a maintainer, then perhaps something will be done.
gmap 7.x.2.x-dev for starters

@haiiro.shimeji:

I just forked a 7.x-2.x branch and merged your branch from hithub in.

This is good news for Gmap.
@haiiro.shimeji, I will contribute a fully reworked marker system which I have deployed in Getlocations. It came from Gmap in the first place and makes full use of the v3 API, proper shadows, anchors, shapecoords and shapetype. A hook can be added that will allow other modules to add their own marker sets. If the Libraries module is present (or better still required) then markers can be stored in the libraries folder or in themes.
Other features will be better pathing to the cachefile, support for public/private and using Drupal's file_stream_wrapper method and use unmanaged to save the file, managed is for uploads and a cache does not need a record.
I will also fix that silly business of 10 letter markers and 26 number markers.

Let me know if you want this.

I think that all functionalities developed by Hutch in his getlocation module will be very useful also in GMap.

Thank you guys for working on this!

Patch in #5 works fine works for me!

@mmowers: try to apply my patch from here : #1218870: Marker managers give wrong path to marker icon when Drupal is not installed at root.

@haiiro.shimeji : are your still porting gmap to Google Maps API v3 ? Because I have some patch I would like to submit to you : #1218870: Marker managers give wrong path to marker icon when Drupal is not installed at root and #1565792: MarkerClusterer is not working and #774078: ExtInfoWindow for GMap - Styling the info window for Google Maps. The last patch is not from me but it would be awesome to have it to. However it needs some works to work with your Gmap version.

@mmowers: sorry but I didn't got this bug and I have no idea where it may come... GMarkerManager is working fine for me.

Good luck !

@mmowers
I make a patch code in http://drupal.org/node/1573062,
This is trick for javascript error, but I cannot make sure markermanager is working correctly..
please try it.

I installed d7.2 version from here http://drupal.org/node/33591/release?api_version%5B%5D=103

this is all on new d7 installationa and i can't make maps appear, there is also a "Google Maps API Key" field in this version which you said will be removed?! Needing some help with this.

Installed location and gmap module, done this before with d6 many times and I know how to do it, but now I can't get any map to display?

released alpha release for 7.x-2.x
please. help with test and bug fix

It sure seems like the API key is not necessary anymore, but it's still a field on /admin/config/services/gmap

Also -- it looks like 2.x-dev was patched to remove the variable_del("googlemap_api_key") but the field on the settings page still creates that variable...

Also -- I'm seeing total removal of the Key in this patch, but according to Google:

The Google Maps JavaScript API v3 does not require an API key to function correctly. However, we strongly encourage you to load the Maps API using an APIs Console key which allows you to monitor your application's Maps API usage. Learn how to use an APIs Console key.

Shouldn't we still be supporting a key?

Attached is a patch that address my last few comments.

Summary:

1. Restored variable_del() in gmap.install
2. Renamed variable "googlemap_api_key" to "gmap_api_key" to be consistent with other vars
3. Removed hard-coded v2 reference
4. Added key back to query
5. Adjusted help text on key field on settings page
6. Fixed Base URL for google maps API service

can someone review this patch for creating initial Goodle v3 dev version for testing on alpha(beta) versions?

#62 looks good for me, but I have no possibility to test it on production now

I applied this patch to the latest 7.x-2.x and it seems to work fine.

I wonder the old variable 'googlemap_api_key' also should be removed when the module is uninstalled,
because this might be registered before the module is upgraded from 7.x-1.x.

If anyone have no problem, I'll commit this patch to 7.x-2.x branch.

I wonder the old variable 'googlemap_api_key' also should be removed when the module is uninstalled,
because this might be registered before the module is upgraded from 7.x-1.x.

Maybe that should go into an update function rather than the install?

#69 looks good for me

commited pushed to 7.x-2.x-dev

Please, open follow up issue for right "deleting old 'googlemap_api_key' "

Thanks to all!!!

this needs backport to D6 as requested from #818638-193: Update to use Google maps API V3

6.x-2.x branch created for this

Shouldn't we get hutch's marker and icon code in here before we start backporting?

At the moment I'm very pushed for time, I don't have a Gmap testrig set up and haven't looked at the Gmap code in at least a year, that is why I did not offer a patch in #73.

Someone who knows Gmap in its current dev state will be much better placed to get this going.

Hi,
I think this needs backport to D6 now as @Hutch is not bringing the marker and icon code in within reasonable time and it is requested from #818638-193: Update to use Google maps API V3, right?
Greetings, Martijn

Hi, can someone make a D6 winzip maybe which I can test. I am not able to execute patches right now. Thanks in advance.
greetings, Martijn

#80 You can try it here http://drupal.org/node/1926766

The last submitted patch, Backport_from_D7_to_use_Google_maps_API_V3_for_D6-1459606-79.patch, failed testing.

When you use a view with GMap display style, marker popups don't display. It works well with 6.x-1.1 version.

This one needs tests

use /tests/gmap.test for that

6.x-2.x-dev works for me after removing the check for a Google Maps key:

Here is a patch

james.morris: I just checked out a git copy and there is lots left to be done. I'm new to gmaps.module, and only about 10 minutes into investigation, but I would say that the map generation itself is good, and markers seem ready, but much of the related functionality is barely converted. I see all sorts of v2 syntax all over the place (GLatLng, GMarker) and the PolyLine/PolyGon stuff looks v2. I also see lot's of commented code all over the place (whole handler functions.)

[edit:] Wanted to add that the geocoding looks like it works with v3.

This month we'll likely have lot's of help as the May 19 deadline is looming. We (wunderkraut) have a couple of clients that need some of the advanced functionality, so I'll add what I can to this effort.

I have finished going though the code and have the remaining items patched for v3 (still testing everything)

I've made the following changes:
1. updated various left over GMarker Calls,
2. made some jquery optimizations (pooled sequential .addClasses)
3. made some google.maps. optimizations (switched some addEventListener to addEventListenerOnce)
4. switched a number of the GPolygon circle implementations to google.maps.Circle;
5. upgraded GPolygon (only found one) to google.maps.Polygon
6. used google.maps.MVCArray in a few places where [{google.maps.point}] was previously used.

As I am new to this thread, I've messaged podarok, who seems to be the most recent maintainer for the code, to see what the best way to push these changes is. I don't know that it makes sense to post a patch with such a large change.

If there is demand, I will consider:
1. posting that patch
2. assigning myself to the ticket
3. helping others with the patch/responding to individual requests.

I am now going into testing on the work that I did, as I upgrade a client site. I should be able to test most of it today.

#92 hutch: the only problem with your fix is that google maps v3 can work without a key now.

https://developers.google.com/maps/articles/v2tov3#newkey

@Jaxxed:

I am afraid that I don't know which part of the Geolocation is failing. We performing client monthly (in this case April's) updates on critical and out of date modules. The client only really pays for the updating, they have to request and pay for any further investigation.

In terms of a test case.

We have the locations field on an events content type and have tried the following with both the V2 and V3 API key.

Add your home address with postcode.

Satisfy any other mandatory fields.

Save the node

View the node

Map should appear (on V3) but centred on the 0,0 long lat.

Sorry if that's not detailed enough. Let me know if you need more.

Cheers

bot

Maybe you lose your key because v2 keys are not compatible with v3

Hi !

I'm testing the 2.0-beta1 with patch from #92.
I've created a new gmap API key V3 and use shapes directly in a template page on a production website : AAAR : that's the color around districts of the region Centre in France.
So it works well on the 1.x plugin but not in the 2.0-beta1.

Here is the way I echo it in my template :
https://gist.github.com/nderambure/5405526

And here is the console error I got :
Uncaught ReferenceError: GLatLng is not defined
in the file gmap_shapes.js at line 35.

Note that my markers work perfectly (with a little CSS adjustements), if I remove the 'shapes' parameter.

Hope it helps !

Hi,

We've managed to get our GMaps geo-location working again by doing the following.

1) Update the GMaps module to 2.0-beta1
2) (Crucial bit) update the location module to version 3.3-beta3
3) Once you've done this update the GMaps with your V3 Google Maps API key.
4) Ensure you have JS Optimise enabled under Performance settings.
4) Clear the caches, then do it again for luck (last cache clear optional).
5) Try create a test node with new address for Geo encoding.
6) Check the node you should now have a geo-encoded map marker.

This is not fully tested. It seems to work but because it relies on beta version of the Gmaps and Location module make you and you clients test thoroughly.

I hope that help.

James

API key is optional in V3 -- if you enter it you can review metrics at https://code.google.com/apis/console

#111 yes!

Hrm, looks like I have some sites that need this upgrade as well, currently on 1.x
Will probably be doing some test upgrades around May 6th, will add my comments on experience with patches after that

upgraded on JS file, to upgade v2->v3 google maps shapes calls. Changed the 'circle' shape to no longer be an rpolygon.

I've tested the circle, lines, polygons (encoded and from points, and from points coming from google.maps.directionsService)

I wasn't sure if this was ready to submit, but I thought that I would post it and see what comments it gets. There aren't really any tests for this kind of a patch.

J

changing to needs review to get the patch I wrote tested

Highlight JS needed upgrade to v3. I did it and then realized that you had some new code for D7 that was v3 compliant.

I didn't like the new D7 highlight approach, and submitted a patch that was tested in the D6, but is D7 compliant (only JS changes). I don't like how highlight.js has only global functions for marker highlights, and how marker.js has highlight events embedded.

Please consider this for inclusion.

http://drupal.org/node/1982292

Some outstanding tasks that I see:

Marker Clustering / Marker Management:

These guys all re-declare the factory.marker(loc,opts) and return a "new GMarker". I can copy over the gmap_marker.js code them, but I am not sure that they are even needed. Integrated code should likely be using an obj.change('addMarker')?

Marker Loader GeoRss

markerloader_georss.sj:21:
var xml = GXml.parse(data);

markerloader_georss.sj:81:
// This sucks, but jQuery and IE don't get along here.
GDownloadUrl(feed.url, getfn(feed.markername));

Perhaps we can return to using $.ajax() now as things probably work much better. Then we won't need a GXml either ($.ajax returns JSON DOM.)

Would module op care to assign particular parts of the backport/migration as higher priority?

Is there anybody in a place to be able to test the georss markerloader code in IE?

I have a little test environnement that does not use intensive shapes as said in http://drupal.org/node/1459606#comment-7312414
But If you have a more recent patch for 6.X, I'll test this afternoon !

Ok I've tested my polygons with the 2.0-beta1 applying both patches from #92 and #116, and it first don't work.
I've made a patch for polygons support, and now it works, but some work has to be done about others shapes regarding styles.

oops, sorry for the non working patch.
New patch below.

uh ?
That's not fixed. As I was saying in #131, there is some more to do, at least in gmap_shapes.js.
Why put this fixed ?

Ok @podarok, thx for explaining :)

Hmmm and there's me having pushed 6.x-2.x-dev to a live site due to thinking it'd stop working by today....

Supported directly until 19th November 2013, and with the wrapper afterwards (for an unknown amount of time).

RE: #139

I looked into the code, and the 6.x code has most of the infoWindow calls transitioned, but not all. The 7.x-2.x code has all of them transitioned. this looks to be a backporting issue.

if your /js/marker.js:116 looks like this:

The D7 code looks like this: (/js/marker.js:

As the D6 code still has the RMTCache, it should look like this:

I've attached a patch that does that. This will likely need to be moved to a different thread.

Note also:
- some bad whitespace was removed
- there was another RMT Cache mistake, where the cache is checked and then the wrong variable is written to the info window

The last submitted patch, gmaps-markerrmterrors-1459606-140.patch, failed testing.