deprecate nodereference in favour of entity reference or relation?

Another entity reference auto-create approach:

http://drupal.org/node/1261574
http://drupal.org/sandbox/michaek/1451014

Here is the auto-create pattern currently used in Pushtape Features with nodereference. It seems like we can just update this code and use entity reference to store the relationship when creating the album node.

/**
 *  Custom submit handler for track node form.
 *  Forces album->track relationship 1-1.
 */
function pushtape_core_track_node_form_submit($form, &$form_state) {

  // If we are creating a new album...
  if ($form['field_album_checkbox']['#value'] == 1 && !empty($form_state['values']['new_album'])) {
    global $user;
    // Create a new album node
    $node = new stdClass();
    $node->type = 'album';
    node_object_prepare($node);
    $node->title = $form_state['values']['new_album'];
    $node->author = $user->name;
    $node->uid = $user->uid;
    $node->language = LANGUAGE_NONE;
    $node->pathauto_perform_alias = FALSE;
    $node->field_tracklist[LANGUAGE_NONE][0]['nid'] = $form_state['nid'];
    // This function operates by reference on our node object, and will add $node->nid.
    node_save($node);
    // Now associate the track with the new album and redirect to it after saving the track.
    $track = node_load($form_state['nid']);
    $track->field_album[LANGUAGE_NONE][0]['nid'] = $node->nid;
    node_save($track);
    unset($form_state['rebuild']);
    $form_state['redirect'] = 'node/' . $node->nid . '/edit';
  }
  elseif ($form_state['values']['field_album_previous_value'] != $form_state['values']['field_album'][LANGUAGE_NONE][0]['nid']) {
    $track_id = $form_state['nid'];
    // Delete from previous album, if there was one.
    if ($form_state['values']['field_album_previous_value'] > 0) {
      $old_album = node_load($form_state['values']['field_album_previous_value']);
      $filtered = array();
      foreach ($old_album->field_tracklist[LANGUAGE_NONE] as $key => $value) {
        if ($value['nid'] != $track_id) {
          $filtered[$key]['nid'] = $value['nid'];
        }
      }
      $old_album->field_tracklist[LANGUAGE_NONE] = $filtered;
      node_save($old_album);
    }
    // Add to this album
    if ($form['field_album_checkbox']['#value'] == 1) {
      $this_album = node_load($form_state['values']['field_album'][LANGUAGE_NONE][0]['nid']);
      $delta = !empty($this_album->field_tracklist) ? count($this_album->field_tracklist[LANGUAGE_NONE]) : 0;
      if ($delta > 0) {
        // Avoid duplicates
        $filtered = array();
        $exists = FALSE;
        foreach ($this_album->field_tracklist[LANGUAGE_NONE] as $key => $value) {
          if ($value['nid'] == $track_id) {
            $exists = TRUE;
          }
        }
        if (!$exists) {
          $this_album->field_tracklist[LANGUAGE_NONE][$delta]['nid'] = $track_id;
        }
      }
      else {
        $this_album->field_tracklist[LANGUAGE_NONE][$delta]['nid'] = $track_id;
      }
      node_save($this_album);
    }
  }
}

http://drupal.org/project/entityconnect now gets my vote

Currently Pushtape associates a track with an existing album reference, or prompts for the new album title that will create an album node upon track node submission. Then it lands the user on the album edit screen for further album info (if needed). This is a 1-2 step process.

Entity Connect caches the form, takes user to new form, and returns them back to the old form. This seems like an unnecessary back and forth of workflow.

Fixed in http://drupal.org/project/pushtape_discography