The Google Fonts view depends on functionality (and interface) in the UI module. It doesn't make sense to add a full dependency, since you can use the module in general without a UI. But we should figure out a way to add a partial dependency for the specific Views page. I'd rather not split this into a separate Google Fonts UI module if we can avoid it, just because that makes it more confusing to figure out which modules need to be enabled for a given task. But that may be the best option.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fontyourface-1460728.patch | 1.45 KB | alexweber |
Comments
Comment #1
alexweber commentedScott,
I've figured out a decent workaround for this.
Patch coming in a few minutes! :)
Comment #2
alexweber commentedNot sure how this works as far as coding standards and general elegance goes, but the solution is actually quite simple: wrap the hook_views_api() implementation with an if statement checking for module_exists('fontyourface_ui').
Works like a charm! :)
Comment #3
sreynen commentedThanks for the patch, alexweber! I committed a slightly different version, with the if statement inside the function instead of outside, since I wasn't sure if module_exists() is always available.
Comment #4
alexweber commentedAwesome! :)
Shame about the different patch I was kinda looking forwards to getting the commit credit :(
Comment #5
sreynen commentedI did give you credit in the commit message, which I think is still standard. I know there's a new --author method, but I'm not sure when that's better than commit message method, so I don't use it.
Comment #6
alexweber commented@sreynen, no prob dude! :)
Using the --author method actually makes the commit show up in the user's d.o profile so that's the preferred method I reckon.
Either way no harm done and I'm happy to have helped!! :)