It would be really nice if the module could pull the descriptions from the Flickr photo and use them for the "alt" or "longdesc" tag. Accessibility is very important for my site, as I have a lot of elderly users.

Thanks for all your hard work!

CommentFileSizeAuthor
#4 alt_tag.patch.txt1.53 KBandrewlevine

Comments

drewish’s picture

drewish commented

humm, not sure how worth while the longdesc would be... it's supposed to be a URL so we'd end up having to add a callback that took a photo id and fetched the description... do-able but kind of clunky. i think you could put it into the alt or title tags in a theme function though.

andrewlevine’s picture

andrewlevine commented
Category: feature » bug

I think drewish is right that the longdesc would add little value to most users and have an inelegant implementation.

However, I think not having working alt tags is a bug. I'm not sure why it isn't working but I'll try to have a patch sometime tomorrow.

Rebecca@category.greenash.net.au’s picture

Rebecca@category.greenash.net.au commented

You're right about "longdesc." Why did I not know it was a URL? I just mentioned it as an option because I'm a bit long-winded. ;-)

Anyway, yeah, "alt" is the right place for that data to show up.

Looking forward to that patch! Thanks, y'all!

andrewlevine’s picture

andrewlevine commented
StatusFileSize
new alt_tag.patch.txt1.53 KB

Sorry this patch took so long.

We actually did have this functionality in the module, it was just broken because we were using the wrong variable name. I went ahead and fixed a couple other places where we were using non-existent variables.

I had to re-save my node to get the alt tags to show up for photos displayed by flickr_filter.

andrewlevine’s picture

andrewlevine commented
Status: Active » Needs review
drewish’s picture

drewish commented

is that $format value not defined? the other stuff looks good.

andrewlevine’s picture

andrewlevine commented

$format was not defined or mentioned anywhere else in the flickr_img function. I'm not sure when it was taken out or even if it was ever there...

drewish’s picture

drewish commented
Status: Needs review » Reviewed & tested by the community

cool, yeah that's one that been slowly dieing off.

andrewlevine’s picture

andrewlevine commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks for the report Rebecca.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)