Change to taxonomy structure on node_save operations breaks newsletter association

+++ b/simplenews.module
@@ -659,7 +659,24 @@ function simplenews_nodeapi(&$node, $op, $teaser, $page) {
+      // Drupal changed its taxonomy format on the insert and update operations
+      // in version 6.24.
+      $terms = array_values($node->taxonomy);
+
+      // Drupal <= 6.23: $node->taxonomy[vid] = tid
+      if (is_int($terms[0])) {

Using $first_term = reset($node->taxonomy) and then checking that would probably be easier than this.

Looks good.

I guess I'd also be fine with just supporting the newest core version, everyone should keep their core versions up to date anyway, but if we already have to code, then let's keep it.

This patch works for me, thanks!

Committed. Thanks!

This probably need to be ported to 6.x-1.x as well?

That branch is pretty much dead but this completely breaks the module and we have 17k reported users who are using 6.x-1.3...

@Berdir, do you mean we should release a 6.x-1.4 ?

First, we actually need to commit yet, but yes, then it will require a release I guess.

Can't reproduce this issue in 6.x-1.x. Back to fixed then.