When an email field fails to validate for the recipient email, it would help if there was some way to indicate *which* selected rows fail validation.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hansfn’s picture

Assigned: Unassigned » hansfn

Sure. It just haven't been prioritized. I'm assigning this to me, but feel free to submit (another patch).

bigjim’s picture

Status: Active » Needs review
FileSize
1.53 KB

The attached patch concatenates the the string "Bad Addresses:" along with a comma delimited list of the e-mails that failed to pass the valid_email_address() function.

hansfn’s picture

Thx for the patch. I'll review it this week - promise ;-)

hansfn’s picture

Project: Views Send Drupal 7 Port » Views Send
Version: » 7.x-1.x-dev
hansfn’s picture

Title: Would help to indicate *which* selected items don't validate » Indicate which selected rows contain invalid e-mail addresses
Status: Needs review » Fixed

Fixed in commit 0bd7bff.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

djdevin’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Needs review
FileSize
1.76 KB

Rolled for D6, can you commit this?

hansfn’s picture

Status: Needs review » Needs work

Is there any reason you didn't roll what I actually committed - ref comment 5 - which was an improved version of the patch from bigjim?

PS! Thx for contribution.

djdevin’s picture

Sorry, I didn't even look! I'll re-roll.

hansfn’s picture

Status: Needs work » Closed (fixed)

OK, I have ported this to D6 - see commit d1644cf. (There is no way to get the actual row number on D6.)