When I add a filter for a Flickr set like the one below
[flickr-photoset:id=,size=m]
it points to:
http://www.flickr.com/photos//
instead of:
http://www.flickr.com/photos//sets/

I'm using Drupal 5.1

Comments

calagan-1’s picture

When I add a filter for a Flickr set like the one below

[flickr-photoset:id=<flickr photo set id>,size=m]

it points to:

http://www.flickr.com/photos/<my id>/<flickr photo set id>

instead of:

http://www.flickr.com/photos/<my id>/sets/<flickr photo set id>
anj’s picture

Yes, this can be fixed by changing flickr.inc so that this line:

    return $person['photosurl']['_content'] . $id;

becomes

    return $person['photosurl']['_content'] . "/sets" . $id;

However, I'm not familiar enough with the module to be sure whether this the right fix, or if this is some more subtle configuration bug. Works for me anyway!

Hope that helps.

Anj

anj’s picture

Whoops, got the slash in the wrong place there...

    return $person['photosurl']['_content'] . 'sets/' . $id;

That's the ticket.

Please note that I am making the assumption that the filter gets the url from the 'flickr_photoset_page_url()' function. My apologies if this is not the cause.

If folks would prefer that even very small changes like this are provided as patches against HEAD, I can set that up. Although it might take a few days to get things set up.

Hope that helps.

Anj

drewish’s picture

patches are best, for small stuff like this i can usually copy and paste it pretty quickly but for anything more substantial the chance of error increases very quickly. i'll try to get this applied today.

drewish’s picture

Status: Active » Fixed

okay, it's committed.

anj’s picture

Thanks. I'll supply patches in future.

Anj

Anonymous’s picture

Status: Fixed » Closed (fixed)