Right now, you get a 404, this seems to be confusing for some users.

Something like "Nothing needs to be confirmed. Maybe the confirmation link has already been used?"

Also need to check if the /ok direct link has a wrong confirmation message (no mail displayed).

CommentFileSizeAuthor
#7 simplenews-1462394-6.patch3.98 KBcorvus_ch
#4 simplenews-1462394-4.patch3.64 KBcorvus_ch
#2 simplenews-1462394-2.patch3.04 KBcorvus_ch

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Assigned: Unassigned » corvus_ch
corvus_ch’s picture

corvus_ch commented
Status: Active » Needs review
StatusFileSize
new simplenews-1462394-2.patch3.04 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/includes/simplenews.subscription.incundefined
@@ -501,8 +501,15 @@ function simplenews_confirm_subscription() {
+        // Redirect and display message if no changes are availlable.

Should be "available", one l too much.

corvus_ch’s picture

corvus_ch commented
Status: Needs work » Needs review
StatusFileSize
new simplenews-1462394-4.patch3.64 KB

Status: Needs review » Needs work

The last submitted patch, simplenews-1462394-4.patch, failed testing.

corvus_ch’s picture

corvus_ch commented
Status: Needs work » Needs review
corvus_ch’s picture

corvus_ch commented
StatusFileSize
new simplenews-1462394-6.patch3.98 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.