Inclusion of full name as well as email address in site settings can cause problems
| Project: | Return-Path |
| Version: | 5.x-1.1 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
If the site E-mail address is specified on the settings page as name@domain.com then all works very nicely.
Also it is possible to include an actual name in the settings page in the format "Joe Bloggs" and this works very nicely. (The bit in quotes is removed from the return-path header.)
However, if there is a space between the "< , or if the quotes are not used at all, then it all goes horribly wrong - either the welcome email does not arrive, or else the welcome email is sent from Joe Bloggs with email address name@domain.com but the return path in the message is set as Joe@servername.ispname.com or whatever, which is of course incorrect.
Can the returnpath module "do what is necessary" to make sure a valid name/email address get passed to sendmail?
NB I also had the install problem described in that issue http://drupal.org/node/140637, but am now using version 5.x-1.1 again as I had this error with that version:
warning: Invalid argument supplied for foreach() in /home//public_html/general51/sites//modules/returnpath/returnpath.module on line 28
#1
Oops that didn't get filtered quite as I wanted. 2nd para should read:
Also it is possible to include an actual name in the settings page in the format "Joe Bloggs"<name@domain.com> and this works very nicely...
#2
I think this is a feature request rather than a bug report, as I'm not sure including a "Name" on the admin/settings/site-information form is supported/intended.
That said, we would like this also.
Is there any way to figure out if "Name" in the site information page is the way to go about this-- it seems not given that contact form e-mails, which have a name and an e-mail address field, do not work this way.
Anyhow if someone can figure this out we can code it and provide a patch.
benjamin, Agaric Design Collective
#3
I've added a check to prevent the
warning: Invalid argument supplied for foreach() in /home//public_html/general51/sites//modules/returnpath/returnpath.module on line 28error from occurring.I've not got time to research the feature request but would be willing to take patches / code suggestions on this.