Menu Attach Block

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

Hi

I like this idea of your module and will be keen to use it.

Manual review :

1) menu_attach_block.css
background: transparent url("/misc/arrow-asc.png") no-repeat scroll;
background-image: url("/misc/arrow-desc.png");
Where do we find this images ?

2) menu_attach_block.info
dependencies[] = views
Are you depending on the view module ?

3) menu_attach_block.module
$output = '' in menu_attach_block_link()
this variable is not used / delete it

4) menu_attach_block.module
$title = '' . check_plain($item['title']) . ' ';
Bad:
print '<a href="/'. check_plain($url) .'">';

Good (URLs must be checked with check_url()):
print '<a href="/'. check_url($url) .'">';
http://drupal.org/node/28984

Tested and found the following minor issue which has been logged as an issue against the project http://drupal.org/node/1508370

Hello,

Using the default drupal 7 theme I got this after adding a block?
Not sure if my theme doesn't support this module?

I then added one to the navigation menu and got picture 2.

Not sure if this is me doing something wrong?

----

For the .info, maybe add this in the user interface package?

----

Possible to maybe use hook_permissions to only allow certain people to do this?

I like the idea for this - but guessing I am doing something wrong.

Automated Review: Ran through Drupal Code Sniffer and all looks fine.
Manual Review: Installed the menu in a fresh D7 installation and it worked as expected.

Looks RTBC to me...

Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.

menu_attach_block_form_menu_overview_form_alter: drupal_add_css(): Your adding the css you've already added by .info - there should be no problem removing this line.

have to go, will continue later

Sorry for the delay (damn exams are such a waste of time)

Great module, code is well documented and the module's functionality is very nice implemented! Found no security flaws,
therefore,

Thanks for your contribution and welcome to the community of project contributors on drupal.org! :)

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

You are welcome. I will soon be using your module !