A few fixes for E_STRICT warnings for:
date_handler_field_multiple .inc (compatible declaration fix)
date_api_filter_handler.inc (compatible declaration fix)
date_api.module (creating default object form empty value/pass by ref deprecation)

CommentFileSizeAuthor
#3 date-1463438-3-d6-2x.patch1.5 KBpatricksettle
date-php5.3-strict-d6-2x.patch2.17 KBpatricksettle

Comments

Status: Needs review » Needs work

The last submitted patch, date-php5.3-strict-d6-2x.patch, failed testing.

arlinsandbulte’s picture

arlinsandbulte commented

I know the last hunk of the patch here has already been fixed: #1162962: E_STRICT notices in date_make_date().
I did not bother checking the other two fixed mentioned above.

It is best to test/create patches against -dev.
See here: http://drupal.org/node/755312

And don't worry about the failing tests on d.o
They are not working right for D6 Date anyway.

patricksettle’s picture

patricksettle commented
Version: 6.x-2.8 » 6.x-2.x-dev
Status: Needs work » Needs review
StatusFileSize
new date-1463438-3-d6-2x.patch1.5 KB

Sorry bout that arlinsandbulte, usually try to make sure I use dev to do this. Must have forgot to swap back. Here's the patch applied to dev. (last hunk dropped of course)

karens’s picture

karens commented
Status: Needs review » Fixed

I don't see the notices, but it can't hurt I guess.

http://drupalcode.org/project/date.git/commit/cee420a

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.