Hi,

I have a field, Boolean=> Single on/off checkbox and i had changed the "On value" and the "Off value" by true and false.

When i try to import my feed, (where the value are true and false) the bug appear and no content are imported, it only work if i change the value for 1 and 0.

Thanks

CommentFileSizeAuthor
#4 boolean_default_value_fix-1463840-4.patch501 bytesf5.andrii
#2 boolean_default_value_fix-1463840-2.patch470 bytesf5.andrii

Comments

windmaomao’s picture

windmaomao commented
Component: Feeds Import » Code

i guess i have similar issue here, boolean 'true' and 'false' are not imported properly.

f5.andrii’s picture

f5.andrii commented
Status: Active » Needs review
StatusFileSize
new boolean_default_value_fix-1463840-2.patch470 bytes

Attached patch fixes this issue but I'm not sure if it not breaks something else.

Status: Needs review » Needs work

The last submitted patch, boolean_default_value_fix-1463840-2.patch, failed testing.

f5.andrii’s picture

f5.andrii commented
Status: Needs work » Needs review
StatusFileSize
new boolean_default_value_fix-1463840-4.patch501 bytes

new version

Status: Needs review » Needs work

The last submitted patch, boolean_default_value_fix-1463840-4.patch, failed testing.

f5.andrii’s picture

f5.andrii commented
Version: 7.x-2.0-alpha4 » 7.x-2.0-alpha8
Status: Needs work » Needs review

changed version

f5.andrii’s picture

f5.andrii commented

#4: boolean_default_value_fix-1463840-4.patch queued for re-testing.

twistor’s picture

twistor commented
Version: 7.x-2.0-alpha8 » 7.x-2.x-dev
Status: Needs review » Postponed (maintainer needs more info)

The attached patch is definitely wrong. We grab the existing field for a very specific reason, and it shouldn't affect anything at all unless you have multiple mappings to the same target.

It looks like the initial bug report is more about the values in the feed matching strings like 'true' or 'false'.

Can someone shed some light with a full export of their importer?

twistor’s picture

twistor commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (fixed)

This has all been pretty much rewritten.