Hi,
Thanks for a great module.
I was having errors on setting recurring events on Sunday. I traced it to a function that ordered the days prior to presenting the form options; date_repeat_dow_day_options_ordered. The function reorders the weekdays, but use of array_shift and array_push loses the array key and creates the bug.
Attached is a patch that worked for me.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | Recurring_Sunday_Errors-1467244-11.patch | 909 bytes | arlinsandbulte |
| #2 | Recurring_Sunday_Errors-1467244-2.patch | 852 bytes | arlinsandbulte |
| date_repeat_options_ordered.patch | 964 bytes | bluetegu |
Comments
Comment #2
arlinsandbulte commentedCode makes sense to me.
Rerolled, so testbot can apply patch.
Comment #4
arlinsandbulte commented#2: Recurring_Sunday_Errors-1467244-2.patch queued for re-testing.
Comment #6
arlinsandbulte commentedHmmm... tests pass for me locally before and after the patch.
Branch tests at http://drupal.org/project/date/testing-status ALSO pass (before patch).
I will try resubmitting the patch in #2 one more time....
Comment #7
arlinsandbulte commented#2: Recurring_Sunday_Errors-1467244-2.patch queued for re-testing.
Comment #9
arlinsandbulte commentedtry testing with right version....
Comment #10
arlinsandbulte commented#2: Recurring_Sunday_Errors-1467244-2.patch queued for re-testing.
Comment #11
arlinsandbulte commentedYep, needed to test against the -dev branch head, not the 7.x-2.2 tag.
Someone else pointed out that the if is not needed... so here is another patch to remove the if statement.
If tests pass, I will commit this.
Comment #12
arlinsandbulte commentedFixed:
http://drupalcode.org/project/date.git/commit/bb27ffc