Having tested this on the demo page (the hierarchy problem, at least) and my own site, I've found that hitting the "Save" button, at the base of the edit column when listing terms in a "categories" vocabulary, seems to wipe out most terms' parent information and language setting (using i18n). It seems to reset my terms to all have a parent of and no designated language.

It did NOT seem to wipe out this information for all terms, however, and I can't find a pattern to explain this.

On the demo site I simply navigated to the edit page for a previously created vocabulary with a hierarchy of terms set up, when I hit "save" (without having made any changes to any terms in any way), the page refreshed, but the terms were no longer nested properly.

Comments

Leeteq’s picture

Leeteq commented

Can someone chime in here with a statement about if this is a confirmed bug or not? Should not stay open as a critical bug now that 1.0 is out. Looks scary...

mdekkers’s picture

mdekkers commented
Version: 5.x-1.x-dev » 5.x-1.0

confirmed, this just wiped out some complex hierarchy. this module is dangerous....

matshep1’s picture

matshep1 commented

Hi,

I used the module before seeing this issue. I now have corrupted nodes (not all nodes affected) with error message "Fatal error: Maximum execution time of 20 seconds exceeded in /usr/local/pem/vhosts/105515/webspace/httpdocs/newsite/modules/taxonomy/taxonomy.module on line 945".

I have tried restoring the database from limited backups but I can't get back to before I used this module.

Here are my efforts to get my head around fixing this. Line 945 of the taxonomy module:

/**
 * Find all ancestors of a given term ID.
 */
function taxonomy_get_parents_all($tid) {
  $parents = array();
  if ($tid) {
    $parents[] = taxonomy_get_term($tid);
    $n = 0;
    while ($parent = taxonomy_get_parents($parents[$n]->tid)) {
      $parents = array_merge($parents, $parent);   /** Line 945 */
      $n++;
    }
  }
  return $parents;
}

Looking at my database my term hierarchy still seems to be intact, but this suggests to me that this module has affected the link between this node and its terms and term hierarchy. If anyone has any ideas how to fix this I would appreciate it. If we can understand how it breaks the hierarchy maybe we can patch this module.

Thanks,
Mat

matshep1’s picture

matshep1 commented

Update:

Digging around in my database term_hierarchy table I just found that one of the terms the affected nodes were assigned to had been assigned to itself as the parent (e.g term id 316 parent 316 !) I changed the parent term in the database and hey presto problem solved.

I can't say for sure that this module did this but it is the most likely candidate as the problem emerged right after I carried out some batch hierarchy changes.

Any hypothesis on how the module may have done this?