To quote Benedikt:

This ignores any overrides by other modules or themes (e.g. display suite "field templates"); not sure how important this is, but maybe there's a better or cleaner way...

I don't follow this one. Since the fields themselves are being added to the TD via drupal_render(), aren't they displaying with any altered output?

Comments

charlie-s’s picture

charlie-s CreditAttribution: charlie-s commented

Is this because the module uses _preprocess_? Would _process_ be better?

bforchhammer’s picture

bforchhammer CreditAttribution: bforchhammer commented

I don't follow this one.

What I was thinking about was the "field templates" feature of display suite, in particular the "expert" view mode which allows to specify custom html elements for wrapping e.g. the field label, all values, one value, etc. My guess is that display suite bypasses normal field rendering for accomplishing that, which would mean that it would not appear in the output produced by this module.

Not sure how relevant/important this is, and either way I'm just guessing and this would need further investigation.

Is this because the module uses _preprocess_? Would _process_ be better?

Aren't we calling both at the moment?

a.ross’s picture

a.ross CreditAttribution: a.ross commented
Version: » 7.x-1.x-dev
a.ross’s picture

a.ross CreditAttribution: a.ross commented
Status: Active » Closed (works as designed)

This issue probably doesn't exist anymore, but feel free to re-open it if you feel necessary.