Issues:

  • A module no longer should explicitly install or uninstall its database schema in hook_install() or hook_uninstall().
  • Schema descriptions are no longer translated
CommentFileSizeAuthor
#2 smsframework-fix_install-1477744-2.patch6.88 KBberdyshev
#1 smsframework-fix_dev_install-1477744-1.patch2.17 KBatlea

Comments

atlea’s picture

atlea commented
Status: Active » Needs review
StatusFileSize
new smsframework-fix_dev_install-1477744-1.patch2.17 KB

Patch with fixes.

berdyshev’s picture

berdyshev commented
Title: DatabaseSchemaObjectExistsException: Table sms_devel_virtualgw already exists » Schema installation isn't compatible with D7 stadards
Component: Miscellaneous » Core Framework
StatusFileSize
new smsframework-fix_install-1477744-2.patch6.88 KB

All modules which have schema installation call drupal_install_schema() function in hook_install() which is not required in Drupal 7.

Patch with fixes attached

zeezhao’s picture

zeezhao commented

Hi - I tried installing the latest 7.x dev version without your patch, but the installation did not work -complained that some tables already existed! Please confirm that your patch fixes this. Thanks.

Maybe you should apply it to latest dev.

berdyshev’s picture

berdyshev commented

yes, this patch fixes those errors. and it is applied to the latest dev version.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

univate’s picture

univate commented
Status: Reviewed & tested by the community » Fixed

committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 5e55a10 on 7.x-1.x, 8.x-1.x by univate: 
    Issue #1477744 by atlea, BerdArt: Fixed Schema installation isn't...