Needs work
Project:
Workflow Named Transitions
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Mar 2012 at 21:13 UTC
Updated:
24 Apr 2014 at 23:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
deekayen commentedJust now starting our D7 upgrade analysis. We'll be bringing this module into 7, but I have no timeline other than 3 months or less.
Comment #2
jeffschulerThanks!
Comment #3
codeelegance commentedInitial commit of 7.x has been committed.
Comment #4
playfulwolf commentedthis one? http://drupal.org/node/433364
it is dated february 25th with one active user...
Comment #5
jeffschulercodeelegance: thanks! Will check it out.
PlayfulWolf: it's still only in version control; not packaged as a release. You can clone the 7.x-1.x branch of the project via git from the Version control tab on the project page.
Comment #6
jeffschulerI was getting errors in a few different places. Here's a patch that fixes them.
Sometimes
$form[$starting_state]is an object:db_delete's execute() is missing parentheses:
targets should be a string instead of an array:
thanks!
Comment #7
jeffschulerOops. we don't need the implode(), we just need one less array() wrapping.
Comment #8
codeelegance commentedjeffschuler: Thanks for that catch. I'm still a beginner here....
I've applied the patch and pushed the branch back up.
Comment #9
jeffschulercodeelegance: awesome. Thanks for committing so quickly.
Please check out the articles on Commit messages and Adding a commit author, as commit authorship credit is always appreciated. :)
Think we get a 7.x dev release out?
Comment #10
codeelegance commentedOops. As stated, I'm a total newbie when it comes to this stuff. I wish etiquette was as simple as code....
Comment #11
guypaddock commentedOne issue I've noticed so far is that hook_install() causes a database error because it tries to install the schema a second time, which is no longer necessary in Drupal 7.
The attached patch corrects this.
Comment #12
guypaddock commentedActually, the entire install logic is broken... hmm.
This should probably use
hook_module_implements_alter()instead of manipulating weight directly.Comment #13
Josh Benner commentedI think setting weight in hook_install() is still allowed/recommended per http://drupal.org/node/110238?
Comment #14
Josh Benner commented... though I suppose it could be a problem if Workflow's weight changes. Yeah, hook_module_implements_alter() is probably a good idea.
Comment #15
deekayen commentedThis is marked needs review, but it doesn't look like there's anything to review. Changing status.
Comment #16
jeffschulerCan we add 7.x-1.x as a dev release on the project page and close this, then?
Comment #17
Mark F commentedHi. I could really do with a D7 version of this right now ;-)
Anything I can do to help?
Comment #18
g089h515r806 commentedA workable version. work with workflow extention, transition type "single button".
I have fixed a lot of update issues.
Comment #19
deekayen commentedThere's a bunch of commented code, functions, and debug stuff left in there. I'm guessing you're not done with it.
Comment #20
jeffschulerRehashing what I said in #16:
There is a 7.x version in git.
Adding a 7.x dev release might help this get fixed faster, by allowing for specific issues with smaller fixes...
Can we do that?
Comment #21
johnvPlease see #2148939: Check compatibility of WNT with 'workflow' module, version 7.x-2.x