Export an entire collaborative book to xml (docbook) so that it can be formatted using xslt (e.g., to rtf or pdf) and printed.

It would also be nice to be able to perform the reverse. That is to import a collaborative book from an xml (docbook) file that is uploaded.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

can someone suggest an xml schema for this? i think we need a general xml schema for nodes. after that, this becomes a simple matter of nesting node elements (I think)

Teto’s picture

Hi,

Is there any news about a such feature ?
All i've found about a docbook schema is here : http://docbook.sourceforge.net/projects/schema/
It seems there isn't much in the docbook cvs about that.

Teto.

puregin’s picture

Here's a list of the Book publishing DTDs I know about:

Name Notes Ref
ISO 12083:1998//DTD Book//EN - this includes ISO 12093:1993//DTD Mathematics//EN Committee standard - very general. Used e.g. by University of California Press. www.xmlxperts.com/bookdtd.htm
DocBook Applications - widely used by Computer book publishers, e.g. O'Reilly. Good support. docbook.org
TEI/TEI-Lite Applications - scholarly/historical/literary documents www.tei-c.org
MIL-STD-38784 (CALS) Applications - Military/Govt/Enterprise publishing http://xml.coverpages.org/mil-std-38784-a1-dtd.txt

I'd highly recommend DocBook as a useable, technically focused, XML DTD with strong toolset support.

puregin’s picture

I'd suggest we start with something very simple.

The patch which I submitted for http://drupal.org/node/1898 wraps each node in <div> tags, with a level, and a node id attribute, for printer friendly output.

We can't rely in general on the contents of a node being XHTML, even if we force output through an XHTML validator such as tidy. So our best bet is to encode the entire contents of a node as CDATA. This gives us hierarchy, and encapsulated contents (of any kind - later this could also be other kinds of data or markup)

This output will be valid XML, with a pretty simple DTD. It is easy to take such a file and write simple XSLT based scripts on the the client side to explode this file into a directory tree of HTML, a single HTML file, or many other formats.

Importing is trickier. It's relatively easy to import an exported file, and update the nodes of the book according to the hierarchy defined by the sectional <div> elements. Importing needs to take care of structure which has changed - child nodes added, deleted, or moved.

It would also be nice to have some client-side scripts to import other formats into this nested sectional <div> based format - for example, to take a directory tree of HTML fragments, and make this into an importable file.

puregin’s picture

FileSize
14.06 KB

This patch enables export of books as XML documents.

The XML is DocBook "at the level of structure", but
node contents are wrapped as CDATA, since we
can't be sure that the contents are valid XML.

Several other bugs/feature requests are also
addressed with this patch:

- Fixes bugs

http://drupal.org/node/1898
http://drupal.org/node/1482
http://drupal.org/node/8049
http://drupal.org/node/1899

Should go a long way towards implementing feature request
http://drupal.org/node/2062

It should also be easy to extend this to produce OPML,
for example.

- Adds about 170 lines, of which more than 100 are comments
- Added doxygen comments
- Made doxygen comment format consistent; fixed minor grammatical slips
- A proper Doctype and more informative HTML element is generated
for printer-friendly HTML output.
- Refactored book_print() to use book_recurse().
- Refactored book_recurse(). Applies 'visitor' callback functions to nodes
during weight/title order tree-traversal. The parameterized
visitor callbacks can be used to generate different kinds of output.
There are many other kinds of operations on books which can be implemented
by writing a pre-node/post-node pair of callback functions: word-count/
statistics gathering, comparison, copying, search and replace...
- Introduced book_export() which uses book_recurse() to generate
DocBook-like XML to export book contents in a structured form.
An md5 hash is computed for each node to help import code to
decide if a node needs to be updated or not.

puregin’s picture

Assigned: Unassigned » puregin
FileSize
14.19 KB

This updated patch adds "weight" metadata, which I forgot to capture in the previous patch. I'm not sure how much other metadata I should include.

puregin’s picture

FileSize
6.64 KB

The attached command-line PHP script may be useful in testing the XML export patch supplied.

Assuming your local version of PHP is built with CLI support and XML parser support, you should be able to run the script against an XML export file generated by the book module with my patch. After you have installed the patch, you can select a book page, click on the 'export XML' link, and save the result as a file, say 'test.xml'. Then run the script. On my system this looks like this:

% ./export2dir.php test.xml

This will produce output that looks something like this:

./explode2dir.php test.xml
md5: 9e8ca98c6a8be35c21f31f7937608acc
weight: 1
md5: 11a1956a1592feac37abee6b469e62c8
weight: 0
md5: ed4c91279d3bed28b56899b75ccaa9aa
weight: 0

It will generate a directory hierarchy, with one directory per book node. Each directory contains a file containing the node contents and a file 'nid' containing the metadata. You can check, for example, that the md5 signature of the contents match the md5 signature recorded with the metadata.

Djun

Dries’s picture

I like the approach taken in this patch! Let's tidy up the menu structure. I suggest changing

book/export   (docbook)
book/print    (plain-text)

to

export/docbook
export/text

If we add OPML-support, it would then become:
export/opmlSimilarly, I suggest renaming 'export XML' to 'export DocBook XML' (or something).

Dries’s picture

Haven't tried it but how does DocBook handle CDATA? Does it come out OK? Read: does it make sense to do it this way?

puregin’s picture

Dries,

The output XML which I've implemented is only 'DocBook-like', not true DocBook. I've been dealing with structure at the top level (book, chapter, section). I've hidden away the actual content inside a CDATA section. The XML is really intended to provide a container for export.

At this point I'm trying to focus on a relatively simple way to do an export/import round trip of the current content format (text/'loose' HTML). Most people would probably not edit this using an XML editor.

I think I can generate a tar/gzip archive of the directory structure I described (output of explode2dir.php) directly on the server, either by calling an external pipeline, or by using the tar/gzip PEAR extension. So the XML format I described would be useful primarily as means to do the import, unless we can think of a better way to import such a directory structure (perhaps via the node_import module?)

How the CDATA section is handled depends on the application. Most XML editors will display this as CDATA, allow the user to edit as CDATA, and to perform edit operations such as cut/paste to convert the CDATA to other XML elements. DocBook formatting applications could do various things - ignore the CDATA; format as 'preformatted', e.g., source listing; or try to do something clever, like attempting to parse and convert the CDATA into real DocBook before proceeding.

To generate true DocBook, we would have to:

  1. emit a document type declaration
  2. decide if we want to export complete documents (i.e., top level elements such as books, articles, set) or document fragments.

The real difficulty is dealing with the content: to convert this into DocBook, we'd have to attempt to map (possibly not well formed) text and/or HTML into well-formed DocBook XML. This would require guessing in many cases, since text/HTML doesn't directly encode the author's intent. A problem with this would be that the content might not be returned exactly as exported in an (export/import) 'round trip' .

If we want to support true DocBook, it would probably be better to do this via an input filter, similar to the PHP input filter - definitely worth pursuing, but perhaps a separate issue?

I will rewrite the patch to make sure that the exported XML validates as a DocBook fragment, and punt off to people who actually want to deal with real DocBook the problem of embedding and converting content. These folks would probably not so interested in round-trip import/export, until we have native DocBook nodes, at which point many of these issues vanish (I hope :)

Regards, Djun

Amazon’s picture

As an active member of the documentation team I would greatly appreciate any ability to export and import content to and from the documentation handbooks. Drupal is slow for editing, and has some usability issues that I will be following up on.

Please consider accepting this as a incremental step to assisting the documentation team and other editors.

Kieran

Dries’s picture

If the goal is to generate books, DocBook-export is key. However, if the output is only DocBook-like, it is only going to be used by a handful of people. I think the code comments should mention that it is only DocBook-like.

If the goal is to import/export books, OPML might be the better choice. I think book syndication (publish/subscribe) is going to be the more popular.

Either way, let's clean up the URL scheme and extend the book_help() function a bit (if not already).

Dries’s picture

I made some changes (URL scheme) and committed this patch to HEAD. Please update your tree before making more changes.

- Can you update the issues affected by this commit?

- I wonder why the release info (md5-sum) isn't stored at XML attributes so it can be parsed/extracted easily. Probably DocBook-specific.

- Firefox did not recognize the XML document as being XML. I think we might have to send the proper headers:
drupal_set_header('Content-Type: text/xml; charset=utf-8');. Haven't checked yet.

Great work Djun.

puregin’s picture

FileSize
22.3 KB

Thanks, Dries.

Here is a new patch, against revision r1.299.

- now generate value DocBook XML (fragments). Level 0 nodes are exported as books; level 1 as chapters, and level 2 and higher as sections.

Content is still wrapped as CDATA, for the moment. I am working on code to generate proper DocBook from HTML, but this will require 1) Tidy, HTMLCorrector or something of the sort, to ensure that the HTML is well-formed XHTML; and 2) XSLT support enabled for PHP. I assume that this will need to be a packaged as a contributed module?

- generate OPML (titles only)

- issue Content-type: text/xml headers for XML output (DocBook, OPML)

- changed URL scheme (single callback for all exports, takes export type as 1st argument)

- merged book_export_html and book_export_xml into a single function book_export with 'switch()' logic to handle different output formats, to support the above URL scheme.

So for example,

book/export/html/154 

will generate printer friendly HTML, while

book/export/docbook/154 

generates DocBook.

- added function _book_get_depth($nid) which computes the absolute depth of a node in a book hierarchy

- printer-friendly HTML is now generated with the exported node embedded to its absolute depth (e.g., level 3 nodes will always be marked-up as level 3 nodes)

- changed name book_node_visitor_print -> name book_node_visitor_html

- added parameter depth to 'post-node' visitor function call

- fixed incorrect parameter to node_invoke_nodeapi() - changed 'view' to 'print' so as to avoid rendering book navigation in printer friendly (or other export format) output.

- Added the new admin/help documentation, updated to include the XML export functionality.

muralik’s picture

when i patch, i get this error, any clues?
failed at line 321

puregin’s picture

I'd guess you are applying the patch to the wrong version. Probably your best bet is to grab the latest version from CVS, since this batch has been applied. Keep watching though because there are some other changes I'm currently working on.

Regards, Djun

killes@www.drop.org’s picture

Status: Needs review » Fixed

patch has been applied.

ax’s picture

Status: Fixed » Active

is xml export supposed to reveal the code of php-pages? have a look at http://drupal.org/book/export/docbook/3 for an example. this strikes me as a security issue, so i'm marking this ACTIVE.

puregin’s picture

Status: Active » Needs review
FileSize
13.62 KB

The attached patch for book module implements the following changes

  • new XML export format includes all attributes required for re-import, supports
    book import (which I am going to provide as a contributed module)
  • DocBook XML export functionality has been removed (to a separate module)
  • Re-architected book_export() to enable external modules to provide support for
    different kinds of export

I have not addressed ax's concert re: visibility of PHP code. I agree this is important.

We could introduce a new permission: 'export books', or go for something more granular,
'export PHP code in books'.

What would people prefer to see here?

Djun

Uwe Hermann’s picture

FileSize
15.89 KB

Rerolled patch to improve format (diff -u -p).

moshe weitzman’s picture

i think 'export PHP code in books' could be an admin pref on the book settings page. no need to have the book vary by role like that. just my .02

Tobias Maier’s picture

there is not just this security issue.
some people like me dont like it that this feature is active by default and that there is no option to unactivate it.
-->think about brochure sites do they need export features available?

Tobias Maier’s picture

should such a feature be available per node / per book or for the whole site? or all together?

moshe weitzman’s picture

i propose that a single setting apply to the whole site

puregin’s picture

I will add such a setting in the book admin page, then.

Djun

puregin’s picture

Priority: Normal » Critical
FileSize
16.33 KB

The attached patch removes the export functionality for DocBook XML and OPML. It also supercedes the previous patch (book_30.patch) which introduced export to 'Drupal XML' functionality.

The removed functionality has been re-packaged; these changes have been been, or will shortly be, submitted as contributed modules.

I feel that this removes non-core functionality from book.module, provides a cleaner architectural delineation, and will encourage additional development for book module and contributed modules supporting book.module and other structural modules.

This change will enable administrators to include/exclude support for exporting various formats by installing/enabling modules, so people who don't want the functionality won't have to put up with it.

At the same time, this patch provides support for external modules to provide export functionality.

I hope that this simultaneous simplification and extension of functionality will meet with approval for the 4.7 release.

Djun

puregin’s picture

FileSize
16.19 KB

Sorry, I created the last patch against an older version of book.module. This patch is made against v333.

Bèr Kessels’s picture

I like this patch
+1

A small issue: IMHO you should remove the export permissions too, from book module.

puregin’s picture

FileSize
17.2 KB

Per the suggestion by Bér, I've reworked the patch (attached) to remove the 'export books' permission from book.module.

Each export format, as supported by contributed modules, can have its own permissions.

By the way, I have adopted Moshe's suggestion and set up a flag 'Allow PHP Export' in the
export_dxml contributed module. Via this option, site admins can enable or disable
export of PHP code in the dxml book export.

Dries’s picture

Status: Needs review » Fixed

Makes sense. Committed to HEAD. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)