Nodes not deleted from plan gives EntityMalformedException error

What kinda fields were in the content type you tried to push?
I cannot reproduce (yet)

function field_deploy_entity_alter(&$entity, $entity_type) {
calls
entity_extract_ids($entity_type, $entity);
And that one causes an error, because the bundle property should be part of the entity but isn't.

More info I found:

MIssing bundle property error
Posted by danielb on December 15, 2011 at 4:09am
This is often used after entity_load(). Note that unlike node_load() which returns an object, entity_load() returns an array of objects - even if you only asked for one. Be sure to get the entity out with something like reset() before passing the result to this function or you will get the unhelpful "Missing bundle property" error.

I'm going to try to reproduce this and print the entity/entity_type in watchdog and see what comes out...

But yeah probably related to media module.

What if we do the following

Create a deploy_entity_delete($entity, $type) { function that reacts on entity deletion.
When it fires we look up the current plans and call deploy_manager_delete_from_plan($plan_name, $entity_type, $entity); on it.

Ok?

Could you test this?

ps: I'm not sure were to place this function
ps2: if you got a broken databse before appliying the patch, it's probably the best to clear the deploy_manager_entities table in phpmyadmin

+++ b/deploy.module
@@ -423,3 +423,13 @@ function deploy_log($key, $status, $message = '', $variables = array(), $timesta
+/**
+ * Implements hook_entity_delete().
+ */
+function deploy_entity_delete($entity, $entity_type) {
+  $plans = deploy_plan_load_all();
+  foreach ($plans as $plan) {
+    deploy_manager_delete_from_plan($plan->name, $entity_type, $entity);
+  }
+}

We should use deploy_manager_plan_load_all() here, since this is only relevant to managed plans.

Otherwise everything looks good here.

I also moved the function to deploy.manager.inc

recidive are you on latest dev? I have no troubles applying the patch. And I rechecked my local commit and I'm one commit ahead of latest commit, so everything should be fine.

(Rechecked several times :p)

http://drupalcode.org/project/deploy.git/commitdiff/d598f3af811c4f45ac22...

Fixed!