When attempting to use Rules and VBO to create a UI for adding taxonomy terms to a deployment plan, I noticed that fetch-only deployment plans were explicitly removed from the drop-down list in the Rules UI when selecting the plan to add to. I can only assume that this is an error, as this is one of the only viable ways of constructing such a plan to use with UUID entity export via Features.

Patch to follow shortly. If this is the intended behavior, I would still like to submit the same patch as a feature request for the same reasons (feel free to change status).

CommentFileSizeAuthor
#7 interdiff.txt1.21 KBManuel Garcia
#7 1483896-7.patch1.29 KBManuel Garcia
#1 1483896--deploy-allow-add-fetch-only-rules--1.patch364 bytesdavidwatson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davidwatson’s picture

davidwatson CreditAttribution: davidwatson commented
Status: Active » Needs review
FileSize
1483896--deploy-allow-add-fetch-only-rules--1.patch364 bytes

Patch attached.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

If this is correct we should just replace the calback function in the info hook as the wrapper has no use anymore.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
CreditAttribution: dixon_ commented

I can't recall why I did like this when implementing this.

If all tests pass with this patch, it should be ok. But tests have to be run locally, because we still have issues with the d.o test bot here.

I'm going to look into this shortly.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Do we have rules tests? I can't find any...

Tests work localy but I don't think they call any rules functions, or do they?

mansspams’s picture

mansspams CreditAttribution: mansspams commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Adds missing item to actions. Seems trivial and important.

HnLn’s picture

HnLn CreditAttribution: HnLn commented

This patch works for me.

Manuel Garcia’s picture

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commented
Status: Reviewed & tested by the community » Needs review
FileSize
1483896-7.patch1.29 KB
interdiff.txt1.21 KB

Addressing #2 and deprecating the wrapping function.