There is a need of changing node/add/faq/?ask=TRUE to node/add/faq/ask. The reason is simple - it is not fully compatible with clean urls and the outcome of it is error during language switching while using local's module (core module) language switching block.

While language switching query is omitted i.e.: node/add/faq?ask=TRUE -> lang-prefix/node/add/faq

Instead of a 'flag' in the query named ask that is accessible by $_GET['ask'] argument named 'ask' accessible by arg() function should be used.

Thus changes goes to the function faq_ask_form_alter : instead $_GET['ask'] ==true use arg(3)=='ask' [arg(3) because of path /node/add/faq/ask].

That change will make this module compatible with Locale and i18n.

Comments

stenjo’s picture

stenjo commented

Would you be able to furnish me with a patch?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

This has the potential for interfering with the FAQ module itself, which owns the "faq" menu entries. Be very careful.

pawel_r’s picture

pawel_r commented
Priority: Major » Normal
Status: Active » Postponed

I don't have a patch right now (not enough time). I see it is not only problem with asking but also with answering. It seems it is general problem with locale module. I've found a patch that helps with it.

stenjo’s picture

stenjo commented
Assigned: Unassigned » stenjo
Status: Postponed » Needs review

Is this still a problem, or is it more to do with the Locale module?

pawel_r’s picture

pawel_r commented

it's a problem while using clean urls. I think that more modules (not only Locale) can have problems with mixed urls (clean and query arguments) in general.

patch linked in #3 solves problem for Local module, but will not for any other.

stenjo’s picture

stenjo commented

Incidently, after modifying the module, it is in many ways no longer dependent on the ask=TRUE query and will behave more on permissions rather than the url query. Have you tested this with the D6-2.2 release?

stenjo’s picture

stenjo commented
Status: Needs review » Fixed

Does not seem to be mutch problem with this, so closing.
Feel free to reopen if there are more issues regarding this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

more info given