make _block_rehash() reusable

i would test ... but it says version 6.x ... I'm at 5.1 ... can I put it there?

Julie

Okay - give me about 2 days and I will test .... just got a lot going on .. (and two munchkins stealing my computer time! LOL)

Without something like this, it doesn't seem possible for a module to remove a block it has previously declared via an API function - rather one would have to delete items from the {blocks} and {blocks_roles} tables, which seems a bit ugly. This is kind of blocking this issue: http://drupal.org/node/156626

I'll look in more detail. Seems the original code neglects to delete form {block_roles} if a block goes away?

File to patch: modules/block/block.module
patching file modules/block/block.module
Hunk #1 succeeded at 210 (offset 57 lines).
Hunk #2 succeeded at 197 (offset 2 lines).
Hunk #3 FAILED at 205.
Hunk #4 FAILED at 231.
Hunk #5 FAILED at 254.
Hunk #6 FAILED at 514.
4 out of 6 hunks FAILED -- saving rejects to file modules/block/block.module.rej

Needs rerolled (Pre-split era?) and also needs to be rolled from the correct directory.

I disagree this being a bug and especially disagree it being critical. Critical means a part of core is totally broken.

Moving to 7.x

subscribing

This seems like an important missing piece of API to me

The theme-key portion of this patch seems to have been implemented by #581118: Blocks admin user interface should not do theme switching

Is this still an issue?

If the function is usable externally it should be renamed as block_rehash()

The theme issue does appear to be fixed as mentioned above; however, I agree with #19 that if the goal is to make this function globally reusable it should be renamed to block_rehash().

I've attached a patch to accomplish this. Note that this patch will break any contrib modules that currently call _block_rehash. An alternative way around this (although not very clean) would be to leave _block_rehash() as is and create a new function block_rehash() that just calls _block_rehash().

there is only a single module in contrib that uses the function so renaming should be managable

patch looks good to me

cd ~/drupal
cat CVS/Root
:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal
cvs -q up
find . | xargs grep -si _block_rehash
./modules/block/block.admin.inc:  $blocks = _block_rehash($theme);
./modules/block/block.module:function _block_rehash($theme = NULL) {
./modules/dashboard/dashboard.module:  $blocks = _block_rehash();
./modules/dashboard/dashboard.module: *   - blocks: An array of block objects from _block_rehash().
./modules/dashboard/dashboard.module: *   - block: A block object from _block_rehash().

API change => Drupal 8.

Surely "private" functions don't form part of the API ??!

So effectively this is just adding to the API which should be OK - even after launch if it's too late for 7.0

Subscribing. I have noticed there are cases in which I want to change which blocks are available programmatically, and would like to have a more elegant way to do so than with a function that has a hardcoded variable.

Does not apply against 8.x so setting to 'needs work' and asking for a re-test.

#20: block_rehash.patch queued for re-testing.

seems not valid for now so could be closed

As task hasn't been closed I've prepared new patch.

Suppose better for d8 move this function to some manager method,
The function is not a part of API because starts from '_' so better not introduce api change here

New patch attached.

1. +++ b/core/modules/block/lib/Drupal/block/Plugin/Type/BlockManager.php
   @@ -121,4 +122,43 @@ public function getCategories() {
   +   * Returns an array of block class instances by theme.
   

   We need a better place to put this. It returns an array of block entities, while this is the manager for block plugins. I think a new class is needed.

2. +++ b/core/modules/block/lib/Drupal/block/Plugin/Type/BlockManager.php
   @@ -121,4 +122,43 @@ public function getCategories() {
   +  public function block_rehash($theme = NULL) {
   

   This needs to be blockRehash()

Closing as a duplicate of #2514998: Reduce fragility in the monolithic BlockListBuilder.