Download & Extend

check for existence of E_DEPRECATED before using it

Project:Feeds
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

in feeds.module it turns off E_DEPRECATED errors, with this comment

// We can safely use E_DEPRECATED since Drupal 7 requires PHP 5.3+

er, no it doesn't - from http://drupal.org/requirements

Drupal 7: 5.2.5 or higher (5.3 recommended)

AttachmentSizeStatusTest resultOperations
feeds.php53.patch754 bytesIgnoredNoneNone

Comments

#1

rebuilt patch against current version. the constant is referenced in two places, both related to SimplePie, so maybe there's a central place to define it if undefined, rather than testing for it.

AttachmentSizeStatusTest resultOperations
feeds-deprecated-1485870-1.patch1.37 KBIgnoredNoneNone

#2

sorry, whitespace error

AttachmentSizeStatusTest resultOperations
feeds-deprecated-1485870-2.patch1.37 KBIgnoredNoneNone

#3

Status:active» needs review

Changing status, as there is a patch.