Organic Group Access per content type

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./og_access_ct.info:    ASCII text, with CRLF line terminators
  og_access_ct.info
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Automatic code review is in attached file.

Manual review: no other problems found.

Hi,

1. In function og_access_ct_install(), you can change the query in drupal structure .

Ex:
Instead of using,

$weight = db_result(db_query("SELECT weight FROM {system} WHERE name = 'og_access'"));
db_query("UPDATE {system} SET weight = %d WHERE name = 'og_access_ct'", $weight + 1);

you can change like this,

$weight = db_query("SELECT weight FROM {system} WHERE name = :name", array(':name' => 'categories'))->fetchField();
db_update('system')->fields(array(
'weight' => $weight + 1,
))
->condition('name', 'mymodule')
->execute();

2. Also you can change the uninstall function,
function mymodule_uninstall() {
// Drop my tables.
drupal_uninstall_schema('mymodule');
}

3.Also in .info file change dependencies into dependencies[].Because you are using two dependent modules which should be stored in array.

Hi sushyl,

Quickly went through the code and here are my 2 cents:

line #16-21, og_access_ct.install
If there is no code running in hook_uninstall you can remove it from the file.

line #34, 35, 45, og_access_ct.module
They seem to be exceeding 80 character limit.

I must mention the README.txt(the most neglected file) is very well written.

@Novalnet: The module is in D6, hence the query structure is fine in this case.

Please do not switch to needs work on such few minor isses

In that case patrik, I think the module is ready to be moved to RTBC. These are the last bit of issues left IMO. (I wasn't sure that applications could be moved to RTBC with minor issues!)

I invite someone to have another look at it before changing the status of the application.

I have downloaded and used it , this is working fine for me.
Thanks sushyl

• Your project page is not very detailed, please have a look at the tips for a great project page.
• t('Visibility of <em>@type</em> posts', array('@type' => $type): note that using % => t('Visibility of %type posts', array('%type' => $type) does the same
• You've to remove the variables you use by variable_del() in hook_uninstall()
• Try to avoid html in t() whenever possible (makes the live of translators easier)
• .module: lines 48, 62 unstructured indentation

I'm afraid this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed (regarding security and correct API usage skills). However, we can promote this single project manually to a full project.

Make sure to resolve point 3 before you create an release.

But this module looks good enough for me to be promoted.

Thanks for your contribution!

I've promoted this module to a full project and now your able to create releases.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

https://drupal.org/project/og_access_ct

The project OG Access CT has been promoted to a full project.
New URL

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

git remote set-url origin USERNAME@git.drupal.org:project/og_access_ct.git