Problem with localization and form operations

zoo33 - June 5, 2007 - 09:06
Project:Taxonomy Batch Operations
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:TBarregren
Status:closed
Description

The button names "Save" and "Delete Selected" are wrapped in t() calls which makes them translatable – which is all good. However, the function taxonomy_batch_operations_form_submit() looks for the untranslated values ('Save' instead of t('Save')) which will make the form break if those strings are translated.

Also, the same function uses $_POST['op'] which is depracated in favor of form_values['op'].

Attached is a patch that fixes this.

AttachmentSize
taxonomy_batch_operations-form_ops.patch839 bytes

#1

dicreat - August 31, 2007 - 17:33
Status:active» fixed

Thanks! It's realy work!

#2

Anonymous - September 14, 2007 - 17:41
Status:fixed» closed

#3

Christefano - December 6, 2007 - 10:14
Status:closed» needs review

This needs to be an open issue for it to be considered.

#4

TBarregren - February 7, 2008 - 22:58

I have added this patch to the patch bundle.

#5

TBarregren - February 7, 2008 - 23:12
Assigned to:Anonymous» TBarregren
Status:needs review» fixed

I have committed the patch bundle, and released a stable version 1.0.

#6

Anonymous (not verified) - February 21, 2008 - 23:14
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.