Download & Extend

Problem with localization and form operations

Project:Taxonomy Batch Operations
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:TBarregren
Status:closed (fixed)

Issue Summary

The button names "Save" and "Delete Selected" are wrapped in t() calls which makes them translatable – which is all good. However, the function taxonomy_batch_operations_form_submit() looks for the untranslated values ('Save' instead of t('Save')) which will make the form break if those strings are translated.

Also, the same function uses $_POST['op'] which is depracated in favor of form_values['op'].

Attached is a patch that fixes this.

AttachmentSize
taxonomy_batch_operations-form_ops.patch839 bytes

Comments

#1

Status:active» fixed

Thanks! It's realy work!

#2

Status:fixed» closed (fixed)

#3

Status:closed (fixed)» needs review

This needs to be an open issue for it to be considered.

#4

I have added this patch to the patch bundle.

#5

Assigned to:Anonymous» TBarregren
Status:needs review» fixed

I have committed the patch bundle, and released a stable version 1.0.

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here