The Bouncing Orange Gallery module provides gallery and gallery item fieldable entities to easily display image galleries on a website.

Sub-modules are also included which contain different ways of displaying galleries which can be selected on a per gallery basis as one of the fields attached to the gallery entity. All gallery displays can be overridden in the theme through templates, css and javascript functions.

The Module has been developed with an eye to easily extend and add gallery formatter displays without touching gallery code.

The module originated out of a need for the developers at Bouncing Orange to save time on galleries from project to project by not having to copy code from galleries in previous projects, work out how we made it and change it to suit the needs of the current project. The aim was to have a module we could simply install with minimal configuration, select how to display it and use css to fit it into the project's design. If a gallery design is significantly different we can easily develop a new formatter module for use in the current project and in the future.

Also contains Views, WYSIWYG and pathauto module integration and uses the fancybox jquery plugin.

Project Page

http://drupal.org/sandbox/maverick619/1451678

Git Repository

git clone http://git.drupal.org/sandbox/maverick619/1451678.git bouncing_orange_gallery

The project is only available in Drupal 7.

The development of this module is sponsored by Bouncing Orange

Comments

targoo’s picture

targoo commented

Hi

Your code is well written but in order to speed up the process of reviewing your code you could try to get a review bonus.

Thanks,

bhamrick’s picture

bhamrick commented
Status: Needs review » Needs work

Hi,

Great work! Very well written. One comment I have is your inclusion of third-party JS libraries. Rather than include them in your module, perhaps include directions for installing in sites/all/libraries or include a decency on a module that enables them (http://drupal.org/project/fancybox)? This may prevent JS conflicts with other modules that use the same libraries.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

jbloomfield’s picture

jbloomfield commented
Status: Closed (won't fix) » Needs work

Automatic Review

Found some issues with ventral.org at http://ventral.org/pareview/httpgitdrupalorgsandboxmaverick6191451678git

Manual Review

  • Nicely written module and have actually used it on a few projects, so know that it is stable.
  • Your git clone url is incorrect in the description, should be git clone http://git.drupal.org/sandbox/maverick619/1451678.git bouncing_orange_gallery
  • I tend to agree with bhamrick about pulling out the fancybox JS into libraries as this would make it easier to upgrade fancybox at a later date as well.

Other than that, I couldn't find any other major issues.

drupik’s picture

drupik commented
Status: Needs work » Closed (won't fix)

Why reopened the issue, working on this module?

jbloomfield’s picture

jbloomfield commented
Status: Closed (won't fix) » Needs work

I know the developer who wrote it, so have become a maintainer. I will see what time I have to see if I can help him get it fixed.

drupik’s picture

drupik commented

ok, then I'm sorry ;)

jbloomfield’s picture

jbloomfield commented

No worries, it has been closed for a while :)

jbloomfield’s picture

jbloomfield commented
Issue summary: View changes

Changed git clone string in body.

maverick619’s picture

maverick619 commented
Issue summary: View changes

Update git repo

maverick619’s picture

maverick619 commented
Status: Needs work » Needs review

Fancybox has been taken out of the module and instructions in README.txt to add to libraries folder. Coder has also been cleaned up again.

jwjoshuawalker’s picture

jwjoshuawalker commented

Confirming ventral reports no issues: http://ventral.org/pareview/httpgitdrupalorgsandboxmaverick6191451678git

You might add more content to the Project page: Screenshot, link to documentation, demo, etc.

Mention the dependencies on the project page & link to their project pages:
Bouncing Orange Gallery depends on the following modules:
* image
* token
* entity
* entityreference
* field_ui
* views

sreynen’s picture

sreynen commented
Title: Bouncing Orange Gallery » [D7] Bouncing Orange Gallery
kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Reviewed & tested by the community

Do you need to load all those libraries in hook_init()? This will cause them to be included on every page load, even when not needed. This is true in all your submodules as well. Try to only load css/js where it's actually used.

In bo_gallery.pages.inc you have a typo 'The update has been performes.'

In bo_gallery_form() and bo_gallery_form_submit() you have some logic for the $user variable, but don't appear to make use of it in that function.

It looks like all the js being added is written by you, can you confirm there are no third part libraries being included?

Lots of code, you may have some trouble supporting multilingual sites due to the use of ['und'], but no major issues found.

----
Top Shelf Modules - Enterprise modules from the community for the community.

maverick619’s picture

maverick619 commented

Thanks for your comments. I'll look into making some updates when I next get a chance.

With regards to the css and js in hook_init I was of the understanding that it was better for aggregation if you include the files in all pages so that pages requiring the css/js don't need separate aggregated files and therefore there's less for the users to download as they go through the site. Is this the correct way do things or should I change my module development to only include css/js when needed?

The only third party js is fancybox which I have added instructions in the README.txt to add to the libraries folder.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

You have a lot of errors about using 'und' at http://ventral.org/pareview/httpgitdrupalorgsandboxmaverick6191451678git. I'd prefer to see the css/js only loaded when needed. But neither of those are serious issues, and it's been over a month, so...

Thanks for your contribution, maverick619!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Enterprise modules from the community for the community.

maverick619’s picture

maverick619 commented

Awesome. Thanks. Will fix up the ventral issues and promote it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Add sponsorship