Panels integration - meta tags available on variant settings pages

I am attaching the patch that was originally posted at #1151938: Panels integration - meta discussion in comment #27.

Known Issues

• Page title does not override the <title> tag, but instead adds a new meta tag in the form <meta name="title" content="...">
• Does not allow data from the Panels configured contexts

Found another issue with the OG Title not being set.

I wrote the patch in #1. Do we want this to set the actual page title? Panels already has a method to do this, so it'll be duplicate functionality IMO.

Hi,

I would not touch the title, this is already been taken care of.

I would love it, if it was possible to set also the input format for the metatags. Some tokens are for example not correct encoded.
Being possible to have php as input format can then correct this.
Thanks for considering.

greetings, Martijn

Hi Damien,
Build new issue, sorry for not doing this earlier: http://drupal.org/node/1787912

My 50cents on this issue is that the Title is already taken care off.
Or you are suggesting that the Meta Title is a different thing from the page title.
I am referring to the page title, which with panels you can set to custom or get from a pane, which is very flexible.

Greetings, Martijn

FYI I deployed a module that does exactly what is described in the OP. It's called metatag_panels and uses the metatag module engine to do the heavy work. It's very much based off metatag_context that comes bundled with metatag module and a module of my own, panels_breadcrumbs.

There are two caveats:

• Only contexts that are of a type that is supported by the Token API work.
• Only one context for each type is currently supported. If you have two 'node' contexts, only the first node is elligible for replacement.

I still haven't found a work around for these two issues. I'm pretty sure we can't do anything about the first one, but I'm not so sure about the second one, so suggestions are welcome.

devuo, This Panels integration is should be within metatag itself. Putting it in a separate module fragments Drupal contrib further. Please focus your efforts on patching metatag.

eosrei, while I understand your opinion, I also understand that the time it takes for a contribution that is not a fix, but a feature, made in a form of a patch to be applied to a module takes a rather long, long time. I prefer to have something out that people can install and use, than nothing at all. I mean, how many people who need this kind of functionality are going to apply patches anyway? If you check the module, you will see that I strictly followed the naming that was used with metatag submodules, thinking such a merge might occur someday. On a wrapping note, I did not even knew that this issue existed at all. I simply needed this functionality wrapped in a module to apply to several projects that are currently being developed at my company, so I built it and shared it with whoever needed it. :)

This isn't just my opinion... :/ I could have created a module instead of patch last year, but the Drupal community encourages collaboration so I didn't: http://drupal.org/contribute/development#collaboration

Please remember to search existing modules and themes first before embarking on your quest, or taking over an abandoned project. You could save yourself some time, and earn community karma by helping others!

Anyway.

What else does this patch need? It is now running on multiple production sites (one for a year now). Per the discussion above, it seems like the titles are correct, but context is needed. Should we just close this issue and use devou's release? I don't want to put any further effort into this, if it will go to waste.