According to Dave Reid the styles support is deprecated and we can go ahead and remove it:

ditch styles completely... I don't know if people out there are using styles (I assume there are) but we've been doing everything we can to get people not using them anymore.

CommentFileSizeAuthor
#9 media-vimeo-remove-styles-1503158-9.patch16.4 KBRobW
#8 media-vimeo-remove-styles-1503158-8.patch15.93 KBRobW
#5 media_vimeo_1503158.patch16.84 KBdrewish
#2 media_vimeo_1503158-2.patch15.54 KBsteinmb
#1 media_vimeo_1503158.patch15.46 KBdrewish

Comments

drewish’s picture

drewish commented
Status: Active » Needs review
StatusFileSize
new media_vimeo_1503158.patch15.46 KB
steinmb’s picture

steinmb commented
StatusFileSize
new media_vimeo_1503158-2.patch15.54 KB

Eh, unable to apply that patch

error: patch failed: includes/themes/media_vimeo.theme.inc:59
error: includes/themes/media_vimeo.theme.inc: patch does not apply

Let's try that again, rolling new patch.

drewish’s picture

drewish commented

Yeah my patch was off of #1443092: Add more video display settings, switch to universal player. so it makes sense it wasn't clean. Are we missing anything else in here?

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented

Doesn't MediaVimeoStyles.inc also needs being removed?

drewish’s picture

drewish commented
StatusFileSize
new media_vimeo_1503158.patch16.84 KB

Yeah I think so... doing that here.

steinmb’s picture

steinmb commented
Status: Needs review » Reviewed & tested by the community

Nothing much have changed and I find no prob. with this patch. It correctly remove all traces of styles.

RobW’s picture

RobW commented

I think you can also remove 

    'media_vimeo_field_formatter_styles' => array(
      'variables' => array('element' => NULL, 'style' => NULL),
      'file' => 'media_vimeo.theme.inc',
      'path' => $path . '/includes/themes',
    ),

Doing the same in Media: YouTube here: #1658102: Remove M:YT support for Styles module.

RobW’s picture

RobW commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new media-vimeo-remove-styles-1503158-8.patch15.93 KB

Added the deletions (heh) in #7 and re-rolled against the latest dev. Moving back to needs review until this version gets some testing.

RobW’s picture

RobW commented
StatusFileSize
new media-vimeo-remove-styles-1503158-9.patch16.4 KB

Whoops, forgot the .info file.

RobW’s picture

RobW commented
Status: Needs review » Fixed

Committed on the new 7.x-2.x: http://drupal.org/node/1503158.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Better formatting of Dave's quote.