Closed (fixed)
Project:
Fivestar
Version:
5.x-1.5
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Jun 2007 at 13:10 UTC
Updated:
17 Jul 2007 at 19:57 UTC
Jump to comment: Most recent file
It doesn't load. I had to back down my jquery version (from the jQuery update module) to the original build included with Drupal 5.1.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | fivestar_update.patch | 3.01 KB | quicksketch |
Comments
Comment #1
taaniel commentedFound solution, file modules/fivestar/jquery.rating.js line 150, remove end() function in line
Comment #2
robloachConfirmed, taaniel's fix worked.
Comment #3
junyor commentedSubscribing.
Comment #4
apsivam commentedConfirming the fix provided by taaniel working here too.
I cannot believe this is so simple which holds me for weeks. Thanks a bunch taaniel.
Comment #5
quicksketchTaaniel's fix, while working with jQuery 1.2, breaks 1.0 implementation. I've tested this change with jQuery 1.0.1 and the jQuery Update module (which I think is 1.1.x). Could another user here verify it works with jQuery 1.2?
Line 150 of jquery.rating.js:
Comment #6
quicksketchHere's an improved patch which gets rid of those nasty .find() functions all over. My jQuery's quite a bit better than it was when this was originally written. I'll commit later tonight.
Comment #7
bsuttis commentedRemoving the end() from line 150 works for me as well.
I tried the patch but it disables the starts again, reverting to the radio buttons display.
Patch was applied correctly, and multiple times on a fresh install, maybe I'm slow? I patched via cygwin and the patched file looks fine. Maybe removing those obj.find() caused it?
Comment #8
bsuttis commentedWell, applying it manually (copy/paste style doesn't cause me trouble), I guess I'll have to look into what I did wrong when patching. Apologies for the time wasting.
Comment #9
quicksketchCool, well I'll assume that it works in some capacity :)
I'm releasing 1.6 shortly. Please don't change the issue title (it's weird... I know).
Comment #10
bsuttis commentedSorry about the title, commenting and following up titles are different but look the same =/
This may may reason for a new issue, but since I've noticed it only after updating jQuery via jQuery Update and following the patch updates in this thread, I figured it might be better here. Onto the issue, I'm noticing that now I can't cancel a vote. Clicking the cancel sign appends the anchor #0 to the url and doesn't remove the vote or change its average. I reverted back to jQuery comes 5.1 packaged with, and the issue doesn't occur.
Anyone else notice this after following this thread's updates?
Comment #11
quicksketchbsuttis, please open a seperate issue. This one has been corrected. Also, try out the 1.6 version released last night and see if the problem persists.
Comment #12
(not verified) commented