Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This patch adds the ability to enable the cvslog module but still have projects that have not been associated with a CVS repository to work as they would if the cvslog module were not enabled (ie. releases can be created by manually uploading a file instead of being created when the packaging scripts are run).
The patch removes the upload file UI if a repository is set for the project; otherwise it does NOT remove the upload UI.
Furthermore, the patch fixes what I would consider a hidden bug--cvs_alter_project_release_form_edit() will include the releases current tag in the tag drop down box when editing a release, even if $release->tag is empty. This is problematic for manual upload releases which are not based on a tag, because the release cannot be edited because the CVS tag selection is invalid. The patch includes the current $release->tag only if it is not empty.
If this "feature request" is turned down, I think the part of the patch that alters cvs_alter_project_release_form_edit() should still be applied, since I think that's a genuine bug that just doesn't get exposed because that piece of code normally would not be executed for a release that isn't based on a cvs branch/tag.
AC
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | cvslog_allow_manual_releases_4.txt | 3.16 KB | aclight |
| #5 | cvslog_allow_manual_releases_3.txt | 3.18 KB | aclight |
| #4 | cvslog_allow_manual_releases_2.txt | 3.21 KB | aclight |
| #2 | cvslog_allow_manual_releases_1.txt | 2.62 KB | aclight |
| cvslog_allow_manual_releases.txt | 1.82 KB | aclight |
Comments
Comment #1
dwwthanks! these are both bugs, and that's definitely a patch. ;) i'll look more closely a little later, but i can't properly review and test this right now...
Comment #2
aclight commentedOk, I wasn't sure if you'd consider this a bug or not. I also just remembered that projects that do not have a repository set still show the CVS access tab on the top of the project's page if the user is an administrator, etc. This updated patch removes that as well for projects not associated with a repository.
AC
Comment #3
aclight commentedSee also this issue in the project module:
http://drupal.org/node/151490
that removes the link from the project summary page to "View CVS messages" and "Developers" for projects with no CVS repository set.
Comment #4
aclight commentedChanging title to better reflect what this patch is doing
Another related problem is that if a manual release is created but no file is selected, and then the release is edited, the UI for adding the file isn't displayed, and thus there isn't a way to add a file after initially creating the release. This was first mentioned at http://drupal.org/node/151649
The attached patch now incorporates the fix for this problem as well.
Comment #5
aclight commentedHere is an updated patch that does the same thing but which does so using
project_use_versioncontrol()function as discussed in http://drupal.org/node/151892Comment #6
aclight commentedHere's the same patch but with
s/project_use_versioncontrol/project_use_cvs/run as mentioned in http://drupal.org/node/151892.AC
Comment #7
dwwThis patch needed some work. In particular:
A) Comment formatting.
B) Some whitespace badness.
C) This:
Should have been this:
D) This:
Should have been this:
However, since I had just committed http://drupal.org/node/151892, I fixed all this myself, tested, and committed to HEAD and DRUPAL-4-7--2.
Thanks!
-Derek
Comment #8
(not verified) commented