Theme output of download tables

That used to effectively test if project_release.module was enabled. Now, it's not really testing anything. I guess I don't know what theme() does if you ask it for something that there's no implementation of. But, this at least needs some clarification (ideally, via a comment in the code), if not actual correction.

If a theme function isn't implemented, nothing bad happens--the function call just returns nothing. So in this case, no release table is printed but there are no error messages either on the page or in the logs. I added a comment to the code to reflect this.

Also, this comment isn't true:
+ * Theme function that calls theme_project_release_table

This is now fixed

Otherwise, I'm a little uneasy about the basic approach of this change. I still get nervous about making "theme" functions out of insanely logic-heavy functions. Seems to cloud the "logic vs. presentation" barrier. My naive view of theme functions is that they should be handed a bunch of data that represents all the logic, and they just convert that blob of data into the appropriate output. Here, we're basically punting all the logic and presentation directly to the themer, which just seems wrong.

I don't think that the theme functions themselves are actually that logic heavy. Of course, they call a logic heavy function (project_release_table()) but I don't see any other reasonable way to do it.

For example, on my site, I have this override:

/**
 * * Causes the project_download_table on the individual project pages
 *   to include ALL official releases and the DEFAULT versions of development releases
 *
 * * Displays a note on the project page if there are no releases for the project
 * * Adds a repository URL link if the project uses subversion
 *
 */
function phptemplate_project_release_project_download_table($node) {
  if (!$node->releases) {
    return;
  }

  $output = '<h3>' . t('Releases') . '</h3>';
  $official_release_table = project_release_table($node, 'all', 'official', t('Official releases'));
  $snapshot_release_table = project_release_table($node, 'default', 'snapshot', t('Development snapshots'));

  if (empty($official_release_table) && empty($snapshot_release_table)) {
    $output .= '<h3><strong>There are currently no releases for this project.</strong></h3>';
  }
  else {
    $output .= $official_release_table;
    if ($node->snapshot_table) {
      $output .= $snapshot_release_table;
    }
  }
  if (project_use_cvs($node)) {
    if ($node->cvs_repository == 2) {   // standard svn.example.com repository
      $repository_link = 'svn://svn.example.com'.$node->cvs_directory; 
    }    
    if ($repository_link) {
      $output .= '<div class="SVN_repository_link"><h3>Subversion Repository:</h3>  &lt;a href=&quot;&#039;. $repository_link .&#039;&quot;&gt;&#039;. $repository_link .&#039;&lt;/a&gt;</div>';
    }
  }
  
  $links = array();
  $links[] = l(t('View all releases'), 'node/'. $node->nid .'/release');
  if (project_check_admin_access($node->nid)) {
    $links[] = l(t('Add new release'), 'node/add/project_release/'. $node->nid);
  }
  $output .= theme('item_list', $links);
  return $output;
}

It wouldn't be possible to do this without modifying the module itself unless a theme function is added.

sorry---#3 was the wrong version of patch