[D7] Commerce Pagosonline

Welcome!

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
(At least this has to be done before switching back to needs review)

Please take a moment to make your project page follow tips for a great project page.

It makes no sense to put your module into a new package (IMHO), you should rename package = Commerce (Pagosonline) to package = Commerce

Please take a moment to create a README.txt that follows the guidelines for in-project documentation.

function commerce_pagosonline_uninstall() {
  drupal_uninstall_schema('pagosonline_log');
}

You don't have to do this, d7 will take care of this automatically.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxjeissonp1502812git

We do really need more hands in the application queue and highly recommend to get a review bonus so we will(/can) come back to your application sooner.

regards

In my humble opinion it would be interested finding some words on what pagasonline actually is, so people don't need to check the webpage for getting a basic introduction.

I suppose the correct GIT-URL would be http://git.drupal.org/sandbox/jeissonp/1502812.git

jeissonp, i would not suggest adding comments which do not add information (in fact they just enoy the followers of your application)

Issue queues are generally treated oldest first as in "last updated", so every past just moves it farer from where you want to have it.

---
The response time for a review is now approaching 4 weeks.
Get a review bonus and we will come back to your application sooner.
See: http://drupal.org/node/1410826

There are still files other than README.txt in the master branch, make sure to remove them.

See also step 5 in http://drupal.org/node/1127732

This is no requirement and therefore no reason to set needs work.

Thanks for your submission. Here's a manual review of the code:

commerce_pagosonline.module, line 5: This @file description does not appear to be correct for this module

commerce_pagosonline.module, line 40: It appears you are using the incorrect wildcard loader argument in hook_menu(), "%order" should probably be "%commerce_order"

commerce_pagosonline.module, line 114: The descriptions of the form items in here are not very helpful, could you add a little bit of text to them? Or are they clear if you have an account with Pagos Online?

commerce_pagosonline.inc, lines 15/16, 19/29: You have to call drupal_set_message() before drupal_goto() in order for your message to set

commerce_pagosonline.inc, line 39: You have defiend a hook, hook_commerce_pagosonline_confirmation, but there is no documentation for it. Please see http://drupal.org/node/161085

commerce_pagosonline.inc, line 51: Please indent the parameters of the db_insert()

commerce_pagosonline.install, line 39: This is not a Drupal/project-blocking issue per se, but it's worth noting that the Drupal Commerce standard for storing amounts is integer, and then formatting on output

commerce_pagosonline_transaction.inc, line 66: Not found should return MENU_NOT_FOUND.

Is there a way to test this module, some sort of developer account or something? I have some other concerns that can't really be addressed without testing.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

here i leave a working copy of this project, i fix some issues and make a couple of changes, this work for me.
Dejo una copia del proyecto, arregle un par de bugs y de problemas, funciono para lo que se necesita.

here i leave a working copy of this project, i fix some issues and make a couple of changes, this work for me.
Dejo una copia del proyecto, arregle un par de bugs y de problemas, funciono para lo que se necesita.

http://montesmarrugo.com/commerce_pagosonline-7.x-1.0-mod.zip

This project application is closed. If you want to take over the code please push it to your own sandbox and create your own project application. Thanks!

All the constants should start with COMMERCE_PAGOSONLINE_* to keep the namespace consistent.

In commerce_pagosonline_response() and commerce_pagosonline_confirmation() you are using values directly from GET and POST which is not secure. In if ($param['estado_pol'] == 5) { what is special about the value 5, and all variable names should be in English.

Otherwise the code seems fine, would be RTBC from me.

Code looks good, thanks for the explanation!

I tested the module actually works very well. Integrate commerce module with pagosonline system. In countries like ours are needed. I've recently taken on some projects that I had to develop and perform payment transactions consistent manner.

Thank you very much.

Thanks for your contribution, jeissonp!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Enterprise modules from the community for the community.