Improve code

The attached patch includes the t() function for "Select Content" and also the l() function for the rendered link in the view.

Attached patch removes one space in views group.

The attached patch uses theme('item_list') instead of building an ul in entityreference_browser_field_widget_form.

Attached patch replaces hardcoded link with l function in entityreference_browser_field_formatter_view.

Please use the patch from comment #12!

Attached patch maps $ on jQuery in the whole javascript file and it supports drupal sites in a subdirectory by using Drupal.settings.basePath when creating the links.

Why you're using $(document).ready(); instead of Drupal.behaviors in the second part of the js? I also added a small comment in the error section of the ajax stuff. I think it's from your current project right? I think we can remove or replace it:

var target = $('div.entityreference-browser-view-widget');
target.html('<p id="artist-load-error">Error text.</p>');
$('#block-request-0').hide();

I also removed the space before the [remove] link.

Okay that was my part, now it's your part drupal community! ;) Please don't forget to attribute authorship to me when you'll commit this patch with adding --author="yan_nick <yan_nick@531118.no-reply.drupal.org>" to the commit message ;)

That's a good point Cyberwolf. A custom build mode for the browser view is good but that requires big changes in the code. Did you take a look in the module?

Please discuss this at #1514604: View mode for entity reference browser view. This issue is for improving the code. David, did you take a look at the patches?

I attached a patch which fixes the coding standards issues from the automated project review. dawehner told me that the views related issues can be ignored.

Because you committed the patch from #1513840: You can add one entity multiple times I created a new patch. Please use this one instead of the patch from #5. But please answer my questions from there.

I merged all the patches into a "monsterpatch" so that it's easier to apply them. Sorry for confusing you with all these patches :)

Okay the patch fails... Here is a new one which works.

Added monsterpatch information.

I think we also should redesign the browser. And adding an entity to the browser via javascript is not cool. So I think first we should use a table, so you can use tablesort later. And the inserting stuff should happens via ajax. I started with rebuildung the browser. Tomorrow I will work on the ajax stuff and the ctools object cache which should we use to store the selected entities.

My current work is attached as patch but you should only apply it when you wanna help us to improve this module. I just attach it to apply my work when I'm at home ;)

Hey David, please review the patch from #14. Patch from comment #15 is just for developing, you can ignore it. Tomorrow I'll work on that. The next big patch is coming :D