Malformed destination uri in FeedsEnclosure [#1515204]

In getFile function in the FeedsEnclosure class the $destination argument for file_unmanaged_save_data is created as: "$destination/$filename", but destination in the case might be "public://" for example which results in a malformed uri. Here is a patch to fix this:

Comment	File	Size	Author
#1	feeds-destination-uri-1515204-1.patch	747 bytes	gnucifer

Comments

Comment #1

gnucifer commented 4 April 2012 at 16:18

Status	File	Size
new	feeds-destination-uri-1515204-1.patch	747 bytes

Comment #2

franz

any

Montréal

commented 23 May 2012 at 13:17

Priority:	Minor	» Normal
Status:	Needs review	» Needs work

I've searched for this bug for some time. It causes private files to be saved as private:///filename which renders them unaccessible.

However, the patch is not discernible to me. It looks like it would make the URI "private:/filename" which is not correct too, right? Should it append "//" instead of "/" ? Or maybe the proper way would be to keep the original "$destination/$filename" with the added clause before it?