Field templates, field refresh and cogwheel problems

In ds_extras_ds_field_settings_alter

We do this:

    // Field styles.
    if ($function != 'theme_ds_field_expert' && $function != 'theme_ds_field_reset') {
      $classes = implode(' ', $values['classes']);
      if (!empty($classes)) {
        $field_settings[$key]['ft']['classes'] = $classes;
      }
    }

In those cases swentel desribes $values['classes'] doesn't exist. So if we check for $values['classes'] that problem is solved.

We have problems on the view and on the save side. I fixed the "classes" issues which was a save issue.
http://drupalcode.org/project/ds.git/commit/81def2069cab8f3714ce301e7d18...

The error in #13 is caused by a variable $settings_form which is not always set.
Since the output of the function can be handled totally different, so for now, it's babysitting time. It would be nice to be able to deal with a certain array, but in vain.

I patched the most simple solution that I could see. Probably this issue has other sub-issues but this one is ready to be reviewed.

I am using views display and the field template overrides are not working.

I tried all of the formats; Full Reset, Minimal and Expert and still nothing.

Thinking that it might be theme related I also tried Bartik.

Thanks,

It is fixed at the moment

Thanks swentel

Pulled the latest dev version and I am still missing the cog. Was going to apply the patch but it says it has already been applied. Am I missing something here or is this still having issues?

cmriley some fields don't have any settings so they don't have a cog.

*if I'm correct*

I went ahead and downgraded to 7.x-1.5 and it put things back the way they should be. I will worry about debugging this later when I have time, if it is not corrected before then.

Thanks

I need to re-open this issue because I get the following error when clicking the cog wheel of an entity reference for an OG reference:

Ein AJAX-HTTP-Fehler ist aufgetreten.
HTTP-Rückgabe-Code: 500
Im Folgenden finden Sie Debugging-Informationen.
Pfad: /system/ajax
Statustext: Service unavailable (with message)
Antworttext: Recoverable fatal error: Argument 1 passed to ds_extras_field_template_settings_form() must be an array, null given, called in /var/www/oeh.aau.at/htdocs/drupal7/sites/all/modules/ds/includes/ds.field_ui.inc on line 2255 and defined in ds_extras_field_template_settings_form() (Zeile 285 von /var/www/oeh.aau.at/htdocs/drupal7/sites/all/modules/ds/modules/ds_extras/includes/ds_extras.admin.inc).

Module versions:
Core: 7.23
DS: 7.x-2.6+1-dev
OG: 7.x-2.3

The patch works.

Strange... but it's ok to commit this.

Fixed. Needs porting.

Doesn't need a fix for D8. Everything changed :)