Images attached using image_attach don't show up in the RSS feed. Would be nice if they did, bonus points for putting it in < enclosure > tags.

Comments

drewish’s picture

StatusFileSize
new1.03 KB

i haven't tested it but this should do the trick.

drewish’s picture

Status: Active » Needs review
StatusFileSize
new1.03 KB
boris mann’s picture

Assigned: Unassigned » boris mann

Setting ownership to myself to test. Nice work, drewish.

boris mann’s picture

Assigned: boris mann » Unassigned
Status: Needs review » Needs work

OK, tested this. See feeds.feedburner.com/bmannconsulting for an example.

A couple of things:
1) uses relative URLs, so it's going to fail a lot of the time
2) the image only shows up as an enclosure, and not as part of the node body -- ideally it would be inserted into node body as well
3) Is "IMAGE_PREVIEW" being appended to URLs? e.g. http://feeds.feedburner.com/image/view/2019/IMAGE_PREVIEW --> this might just be feedburner / Safari looking at the feed, not sure.

drewish’s picture

Status: Needs work » Needs review

well this should fix the relative URLs. i'm not sure about putting them in the body... i guess we could but i'm not sure it's a good default... and i'd really like to avoid putting any more settings on the admin/content/types/FOO pages.

and re that IMAGE_PREVIEW it's a constant defined in the image module. are you sure you're running a recent version?

drewish’s picture

StatusFileSize
new1.05 KB

stupid preview...

boris mann’s picture

Title: Show image_attach in the RSS feed » Put image_attach in the enclosure part of the RSS feed
Status: Needs review » Reviewed & tested by the community

Recent version: um, no, somehow missed 1-1 --> 1-3. Updated now. Works great, shows the preview size as the enclosure.

I agree that setting-itis is bad. I like to think of this as basically displaying in RSS as it would on a node view (i.e. inserting the image into the body). But, I changed the title of this feature to reflect that this is about adding enclosure support.

Let's leave it at that for now, I set RTBC.

drewish’s picture

Status: Reviewed & tested by the community » Fixed

okay, i've committed that. i suppose it would make sense to get the image into the post at some point but that can be a new issue.

sillygwailo’s picture

Just a note that the patch in #6 isn't in DRUPAL-5--1-3, but it is in DRUPAL-5.

drewish’s picture

Richard Eriksson, you're right. I think Boris was saying that after upgrading to 1.3 the patch worked. When I get the other 1.3 related bugs worked out (hopefully this week) I'll create a 1.4 release that will have this included.

Anonymous’s picture

Status: Fixed » Closed (fixed)