Images attached using image_attach don't show up in the RSS feed. Would be nice if they did, bonus points for putting it in < enclosure > tags.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | image_attach_152358_1.patch | 1.05 KB | drewish |
| #2 | image_attach_152358_0.patch | 1.03 KB | drewish |
| #1 | image_attach_152358.patch | 1.03 KB | drewish |
Comments
Comment #1
drewish commentedi haven't tested it but this should do the trick.
Comment #2
drewish commentedComment #3
boris mann commentedSetting ownership to myself to test. Nice work, drewish.
Comment #4
boris mann commentedOK, tested this. See feeds.feedburner.com/bmannconsulting for an example.
A couple of things:
1) uses relative URLs, so it's going to fail a lot of the time
2) the image only shows up as an enclosure, and not as part of the node body -- ideally it would be inserted into node body as well
3) Is "IMAGE_PREVIEW" being appended to URLs? e.g. http://feeds.feedburner.com/image/view/2019/IMAGE_PREVIEW --> this might just be feedburner / Safari looking at the feed, not sure.
Comment #5
drewish commentedwell this should fix the relative URLs. i'm not sure about putting them in the body... i guess we could but i'm not sure it's a good default... and i'd really like to avoid putting any more settings on the admin/content/types/FOO pages.
and re that IMAGE_PREVIEW it's a constant defined in the image module. are you sure you're running a recent version?
Comment #6
drewish commentedstupid preview...
Comment #7
boris mann commentedRecent version: um, no, somehow missed 1-1 --> 1-3. Updated now. Works great, shows the preview size as the enclosure.
I agree that setting-itis is bad. I like to think of this as basically displaying in RSS as it would on a node view (i.e. inserting the image into the body). But, I changed the title of this feature to reflect that this is about adding enclosure support.
Let's leave it at that for now, I set RTBC.
Comment #8
drewish commentedokay, i've committed that. i suppose it would make sense to get the image into the post at some point but that can be a new issue.
Comment #9
sillygwailoJust a note that the patch in #6 isn't in DRUPAL-5--1-3, but it is in DRUPAL-5.
Comment #10
drewish commentedRichard Eriksson, you're right. I think Boris was saying that after upgrading to 1.3 the patch worked. When I get the other 1.3 related bugs worked out (hopefully this week) I'll create a 1.4 release that will have this included.
Comment #11
(not verified) commented