Multiple undefined variables [#1524664]

Working with PHP 5.3 and 6.x-3.x-dev there are multiple cases of undefined variables.

notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined variable: unpublished in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/templates/node.tpl.php on line 64.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined variable: unpublished in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/templates/node.tpl.php on line 64.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined variable: unpublished in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/templates/node.tpl.php on line 64.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined variable: unpublished in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/templates/node.tpl.php on line 64.

And on /admin

notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.

And on /admin/build/themes

notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: style in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 41.
notice: Undefined index: style in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 41.

and in the adaptive theme config:

notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 125.
notice: Undefined index: horizontal_login_block_overlabel in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 70.
notice: Undefined variable: output in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 78.
notice: Undefined index: slider_login_block_enable in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 376.
notice: Undefined index: slider_login_block_enable in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 393.
notice: Undefined index: horizontal_login_block_overlabel in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 70.
notice: Undefined variable: output in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 78.
notice: Undefined index: slider_login_block_enable in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 376.
notice: Undefined index: slider_login_block_enable in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 393.
notice: Undefined index: #type in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 83.
notice: Undefined index: class in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 70.
notice: Undefined index: style in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 41.
notice: Undefined index: style in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 41.

Patch attached in next comment.

Comment	File	Size	Author
#4	adaptivetheme-6.x-3.x-dev-1524664-2.patch	24.03 KB	jeff veit
#1	adaptivetheme-6.x-3.x-dev-1524664.patch	22.11 KB	jeff veit

Comments

Comment #1

jeff veit commented 9 April 2012 at 19:38

Status	File	Size
new	adaptivetheme-6.x-3.x-dev-1524664.patch	22.11 KB

Patch attached.

Not sure if the $Id$ that are altered are shown as edited a consequence of my editor or what. Maybe you know.

Comment #2

Jeff Burnz commented 9 April 2012 at 23:11

the $Id$ is from old CVS days, we dont use them anymore since we moved to GIT on Drupal.org, I will apply this patch when I get a moment, I am really struggling for time with Drupal 6 stuff, could be one more maintenance release in there.

Comment #3

jeff veit commented 9 April 2012 at 23:52

I'll delete $Id:$ them where I find them. And I'll re-roll the patch: found another couple of uninitilization cases and fixed them.

Comment #4

jeff veit commented 10 April 2012 at 00:11

Status	File	Size
new	adaptivetheme-6.x-3.x-dev-1524664-2.patch	24.03 KB

Looks like there are an awful lot of $Id$ around. Case for mass delete but that will look like a mega patch, touching just about every .inc and .php file. Not doing that as part of this issue - just in the files I edit.

Comment #5

jeff veit commented 10 April 2012 at 00:28

Found more. Working on them.

Comment #6

jeff veit commented 10 April 2012 at 00:50

Okay - so the next batch I found were as a result of a new installation, and going to admin/build/themes/settings/my_adaptive_theme for the first time: there were a bunch of undefined settings. I'm not going to fix those, but I reckon that maybe they should be added to the .info file.

notice: Undefined index: equalize_leaderboard in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_header in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_secondary-content in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_content-top in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_content-bottom in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_tertiary-content in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_footer in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_leaderboard in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_header in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_secondary-content in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_content-top in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_content-bottom in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_tertiary-content in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.
notice: Undefined index: equalize_footer in /var/www/virtual/drupal-6.x-dev/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 251.

Comment #7

Jeff Burnz commented 6 May 2012 at 18:06

Man, I just cant get this patch to apply, any pointers? I am stumped.

Comment #8

Jeff Burnz commented 7 May 2012 at 18:09

Status:

Active

» Closed (fixed)

Jeff Veit, I ported the patch manually, thank-you very much. I made one change afterwards and decided to remove the theme_button overrides, that was always a pita to be frank. Its better not to have it I have found.

I made the commit and gave you attribution.

Multiple undefined variables

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

News items

Our community

Documentation

Drupal code base

Governance of community