Closed (fixed)
Project:
Display Suite
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Apr 2012 at 02:31 UTC
Updated:
28 Apr 2012 at 21:00 UTC
The Views title is getting duplicated on all ds 7.x branches 1.5, 1.x, and 2.x when using Views Title field and the results are empty.
The page title hides correctly when the results are not empty.
Comments
Comment #1
joelpittetTrying to track down where this happen, leads me to believe this may not be a DS issue.
hook_entity_view_alter doesn't seem to be firing for a view with no results because there is technically no entities being rendered.
That is my two cents... I wonder if there is another hook for this?
Comment #2
swentel commentedCould you check if ds_vd_render_title_field() is called twice (maybe change the value it's return there) ? Or inspect with firebug to see what wrappers are printed ? The ultimate thing is to add a debug_bactrace() (or ddebug_backtrace from devel) to find out why (although it's hard for me to tell where to actually place the backtrace).
Comment #3
joelpittetds_vd_render_title_field is not getting called twice. It's getting called and rendered once as expected.
It's the original page title that is getting added because hook_entity_view_alter doesn't fire to hide it when no entities are rendered in the view. Just a no results view global text.
Comment #4
swentel commentedHmm, and this is a page view right ? I should test it because I should see what happens :)
Comment #5
swentel commentedAlso, I always see two titles anyway on a page view if I manage the layout through views and drag the views title into a layout, so I'm guessing this is rather by design than a bug.
Comment #6
joelpittetNo Results - Page View
https://skitch.com/joelpittet/81ucr/join-the-team
With Results - Page View
https://skitch.com/joelpittet/81uqd/join-the-team
Comment #7
swentel commentedOk, so this means you configured the node to remove the page title, right ? That's actually been reverted in the latest dev since that's actually wrong behavior. A node which is not rendered as it's own page, shouldn't have control over that. That would mean we should add support for that page title option also for views, which I know 've set to won't fix a couple of times, but maybe I'll have to reconsider. However, I'm not sure if I can make that work since the magic for views happens in a preprocess function, which will probably to late for the page title to change.
Comment #8
swentel commented#1446554: Hiding the page title on the full page view mode is bleeding it's option to views displays is probably what made title come back again.
Comment #9
swentel commentedOk, so that fix mentioned in #8 actually isn't really fixed for hiding the titles. I've been able to reproduce this with a full nodes in my right sidebar where I opted to hide the page title. This shouldn't happen at all as it's wrong behavior.
Comment #11
swentel commentedOk, Display Suite views now has the option to hide title (not rewrite at this point as I don't see much value in that) when managing the layout.
Only 7.x-2.x for now, will see if people want this for 7.x-1.x as well.
http://drupalcode.org/project/ds.git/commit/aabf0c0
(accidentily delete the patch already on my local system)
Comment #12
joelpittet1.5 seems a bit more stable than 2.x right now, so I am putting my hand up for 1.x too. But I will give 2.x another try and submit a few more bugs if they are still there(field form settings were failing last).
Comment #13
joelpittetGreat work, that solves 2.x
Comment #14
aspilicious commentedJust leave this fixed for now, so we can track this better. It will close automaticly after two weeks.