Fix for emails

Formatting:
I assume you mean ==============? My intention was to clearly define the beginning and end of multiline values, not for it to be strong. I find it quite difficult to read value if the key is on the same line as the first line of the value, or if there is no distinct indicator of where the value starts. ========== probably isn't the best way of doing that, but anything with text is going to be awkward.

Another option is to make an html email, use mime mail module to send it, and let mime mail convert it to text if necessary. I think it has a fairly standard library to textify html. Obviously that creates a dependency on mime mail module, but abstraction is a good thing.

TODO:
I agree. I wasn't sure what would be the best way to deal with the double-key issue. So I figured it'd be best to have this conversation first, then come back to it later.

Unique IDs:
I understand the reasoning for having two unique identifiers, however I wonder if it will cause more headaches than it will solve. If handling large numbers of submissions is important, then obviously the integer key makes a better unique id. Why not use the integer keys in $form_values['submitted_tree']? That will solve one issue here, and probably more in the future. Yes, debugging output from the form will be a little less easy, but code will be cleaner. Also php probably works faster on arrays indexed by integers rather than associative arrays.

Btw, I assume the keys in $form_values['submitted_tree'] are the keys of form components submitted to the the drupal form API. Is that right?

Also, why are the integers of CID seemingly random? Is there any reason not to use incremental natural numbers? Like with mySQL's autoincrement, or drupal's sequences table. i.e. 1, 2, 3, 4... That would save space and possible make indexing and database querying faster, in addition to being more readable.

Another option is to:

foreach ($form_values['submitted_tree'] as $submitted_key => $submitted_value) {
  foreach ($node->webformcomponents as $component) {
    if ($component['key'] == $submitted_key) {
      $message .= $component['name'] .": $submitted_value\n";
    }
  }
}

However that's quite crufty, and probably not efficient compared to

foreach ($form_values['submitted_tree'] as $submitted_key => $submitted_value) {
  $message .= $node->webformcomponents[$submitted_key]['name'] .": $submitted_value\n";
}

I noticed while creating a form yesterday that although the key value of a form component is expected to be a unique string, there are no checks for that. I created two components with the same key, and webform didn't complain. The only issue was that the first of the two components didn't display. If a string is going to be used for a unique identifier, the database should reflect this and webform should check for uniqueness. Should I create a new issue for this?

I wouldn't put the redirect POST thing

I'm not sure what you're refering to here

Created new issue: http://drupal.org/node/153430

I guess that means the function needs to deal with the issue as I previously suggested, with the nested for statements. Or do you have any other suggestions?