Repeatly selecting roles when adding a user [#1529314]

After enabling autoassignrole module, i set some roles for users to choose, and make it required.
Then i create a user from backend, found there're two forms for selecting roles, this may cause conflicts.

Comment	File	Size	Author
#5	autoassignrole-n1529314-5.patch	709 bytes	damienmckenna
#2	autoassignrole_hide_user_choice_fieldset-1529314-2.patch	709 bytes	anzi31
#1	AutoAssignRole.pdf	108.82 KB	anzi31

Comments

Comment #1

anzi31 commented 26 September 2012 at 05:41

Status	File	Size
new	AutoAssignRole.pdf	108.82 KB

This occurs only if you have both Automatic and User Choice enabled.

Comment #2

anzi31 commented 26 September 2012 at 20:30

Component:	Miscellaneous	» Code
Status:	Active	» Needs review

Status	File	Size
new	autoassignrole_hide_user_choice_fieldset-1529314-2.patch	709 bytes

When a user with a role that has the "Administer users" permission visits the admin/people/create, and the "user role assignment" is enabled, then the "user choice" fieldset should be hidden to avoid confusion.

Possible patch:
a. In autoassignrole.module, change:

function autoassignrole_form_user_register_form_alter(&$form, &$form_state) {
if (variable_get("autoassignrole_user_active", 0)) {

function autoassignrole_form_user_register_form_alter(&$form, &$form_state) {
if (variable_get("autoassignrole_user_active", 0) && !user_access('Administer users')) {