Currently, the drupal-org.make file for this distribution references libraries zipballs on apps.getpantheon.com. This isn't really kosher; it should be pulling from the proper upstream libraries referenced at http://drupal.org/packaging-whitelist so users are getting these things from official sources. If further modifications are needed, they should be done in the drupal-org.make file with patches, additional libraries lines, etc.

According to research from various README.txts, there are some modifications to these libraries, which according to my creative use of diff, includes (I'll update this as I go):

TinyMCE

- Using version 3.4.7: https://github.com/downloads/tinymce/tinymce/tinymce_3.4.7.zip (URL should be fine, whitelist-wise)
- A skin called "oa_inlinepopups" is added to which I could not find reference to anywhere on the Internet, so I assume this is custom, from OpenAcademy. Looks like it's a derivative of the clearlooks2 skin, based on the comment at the top of the file. Possibly the only difference is renaming '.clearlooks2' to '.oa_inlinepopups' everywhere, and some adding nicer syntax formatting, but I didn't look too closely at the diff. There were a ton of changed lines, though.
- A TinyMCE plugin called "pdw" is added. I *think* this comes from http://www.neele.name/pdw_toggle_toolbars/ (diff seems to only show whitespace changes). License information is unspecified. :\ But presumably, it takes the same license as TinyMCE, same as Drupal modules do. Needs an issue to discuss in http://drupal.org/project/issues/drupalorg_whitelist
- The spellchecker plugin has been updated (TODO: To what version, any hacks?)
- The README.txt also references "Adding the Cirkuit skin at jscripts/tiny_mce/themes/advanced/skins" however that did not actually show up in my diff (I downloaded the 7.x-1.0-beta2 release). That library has the same problem w/ no license specified, however. :\ I sent an email to the project owner to inquire. I'm a bit nervous about reference to famfamfam icons at http://www.cirkuit.net/projects/tinymce/cirkuitSkin/. Last I knew, those were not GPL-compatible.

SolrPhpClient

// TODO.

MarkItUp

// TODO.

jQuery Cycle

// TODO.

Respond.js

// TODO.

I'd love to see this fixed, because right now it's *really* hard to download and install this distribution, and it looks like it'd be awesome. And because the apps.getpantheon.com URL was removed from the whitelist (with good reasoning, IMO), it's actually impossible to roll a new release with all the various dependencies in place, hence the critical. I'm happy to help with this.

Comments

populist’s picture

populist commented
Assigned: Unassigned » populist

Thanks for the detailed notes and I will work to get these straightened away for the next version.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Oh np. Sorry I didn't finish up. :( I'd have time to work with you on this next week though! Really want to get this distribution back to a one-click download but with the proper upstream integration.

populist’s picture

populist commented
Status: Active » Fixed

I updated the install profile today (http://drupalcode.org/project/panopoly.git/blobdiff/67e9650083a3610d8704...) to use the approved upstream sources. Sadly, had to remove support for a custom TinyMCE skin and a custom inline popups skin due to limitations with the WYSIWYG module, but hopefully #313497: Allow configuration of advanced editor settings can help solve this eventually.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Ok, I tried to package this up in http://drupal.org/project/webchick_profile in the 7.x-0.1-unstable15 tag, and got the following errors when trying to make a release:

The library 'SolrPhpClient' cannot be downloaded from [error]
http://solr-php-client.googlecode.com/files/SolrPhpClient.r60.2011-05-04.zip,
the URL must be in the whitelist available at
http://drupal.org/packaging-whitelist.
The drupal.org validation check failed -- see [error]
http://drupal.org/node/1432190 for more information.
Once these errors are fixed, commit the changes to your drupal-org.make, move the release tag for your project (check the Git manual to learn how to move tags if necessary), and submit the release node again.

I'll go investigate.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

The whitelist entry for SolrPHPClient uses ^http://code\.google\.com/p/solr-php-client/downloads/.+$

However, I checked https://code.google.com/p/solr-php-client/downloads/detail?name=SolrPhpC... and the URL specified in the .make file is right. So added this:

^https://solr-php-client\.googlecode\.com/files/SolrPhpClient\..+$

...to the whitelist entry. Will try again in a few mins once Varnish clears.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

WOOHOO! http://drupal.org/node/1555424 demonstrates that the drupal-org.make and drupal-org-core.make file are working properly now! :) Thanks a lot, populist!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.