Even if I only have ~4000 nodes with nodeword data to migrate, it still creates batche operations consisting of all 20,000 of my nodes where it does nothing for most of them.

Rather than selecting every nid in the node table, we should just select nids for nodes that have data in nodewords.

CommentFileSizeAuthor
#3 metatags_quick-slow_migration-1532666-3.patch443 bytesiamEAP
#1 metatags_quick-slow_migration-1532666-1.patch1.59 KBiamEAP
metatags_quick-slow_migration-0-0.patch1.4 KBiamEAP

Comments

iamEAP’s picture

iamEAP commented
StatusFileSize
new metatags_quick-slow_migration-1532666-1.patch1.59 KB

Mistakes in my understanding of the DB API.

iamEAP’s picture

iamEAP commented
Status: Needs review » Needs work

Nevermind, this actually doesn't appear to be solving anything.

iamEAP’s picture

iamEAP commented
Status: Needs work » Needs review
StatusFileSize
new metatags_quick-slow_migration-1532666-3.patch443 bytes

Ah, the real problem was in the node_save(). Very expensive; it's better to just save the fields attached to it.

The above work may still be relevant, but this patch is a significant improvement.

Sorry for all the noise as I work through this.

valthebald’s picture

valthebald
Location Sofia
commented
Status: Needs review » Fixed

I think this approach completely makes sense.
Committed to 7.x-2.x-dev, thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.