Problem/Motivation

When an item in the Space Tree is selected, it get 120% size. This sometimes causes ugly line breaks in the graph.

Proposed resolution

Change colour of the selected item, but don't make it larger.

Remaining tasks

Find a way to implement.
Implement.
Test, commit.

CommentFileSizeAuthor
#2 1535338-2-dont_make_selected_item_larger.patch347 bytesitangalo

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Can you please check for styling defined by this module?

This is not happening on http://thejit.org/static/v20/Jit/Examples/Spacetree/example1.html
(As a side note I discovered the 'set as root' there ... looks nice)

itangalo’s picture

itangalo commented
StatusFileSize
new 1535338-2-dont_make_selected_item_larger.patch347 bytes

Found it!
Patch attached – it turned out that this was CSS things that even I understand. :-)

itangalo’s picture

itangalo commented
Status: Active » Needs review
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Assigned: Unassigned » mrhanlon

I want to know what Matthew think: should we override thejit settings as a whole or not?

For this issue
... the selector is easy to override by site builders
... the out of the box experience is a little ugly for long titles.

When clicking through http://drupal.d7/admin/modules/graph I like the dense red.

I'm ++ not resizing the font. But what else should we fix?

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes

Crossed off two tasks.