Photowall

welcome,

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxtanmayk1536658git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

A very nice module - I can see myself using this in the future!

A couple of suggestions:

1) Implement hook_help() to give the user more info on the configuration. I know all the instructions are in the readme file, but from a UX perspective I think hook_help() would be useful.

2) The thumbails that appear on the node for the photowall display are very small. I played with the zoom factor, but I suspect this is for the actual photowall display. Can you control the size of the thumbnails?

Otherwise I would say there is little else to do on this module. It installed cleanly and appears to work well.

Sorry... forgot to change the status on my last post.

Why needs work?

implementing hook_help is not a requirement.
and the second point you mention is a question.

Hi patrickd, probably a bit hasty changing the status, but after using the module the thumbnails really are small and I could not easily see a way of changing them. IMHO, this module does need a little more work.

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

FILE: ...www/drupal7/sites/all/modules/pareview_temp/test_candidate/photowall.js
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | There should be no white space after an opening "{"
 1 | ERROR | There should be no white space before a closing "}"
--------------------------------------------------------------------------------


FILE: ...drupal7/sites/all/modules/pareview_temp/test_candidate/photowall.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 11 | ERROR | Expected "switch (...) {\n"; found "switch(...) {\n"
--------------------------------------------------------------------------------

1. Remove php = 5.2 from info file, as it is the same requirements Drupal core has.

2. Is it not possible bundling the jquery plugin into the module, as does drupal core? I suppose this does not pose problems as jquery is under GPL

        'description' => $t('You need to download the !name and move downloaded js file into the %path folder of your server. The path to the file must be !plugin_path', array(
          '!name' => l($t('JQuery Photowall plugin'),
            'https://nodeload.github.com/creotiv/jquery-photowall/zipball/master'
            ),
          '%path' => $path,
          '!plugin_path' => '/sites/all/libraries/jquery-photowall/jquery-photowall.js',
          )

3. it's more readable if commas where at the end of line:

    PhotoWall.init({
      el: '#gallery'
      ,zoom: true
      ,zoomAction: 'mouseenter'

---
The response time for a review is now approaching 4 weeks.
Get a review bonus and we will come back to your application sooner.
See: http://drupal.org/node/1410826

You could for example start by evaluating my own project:
http://drupal.org/node/1302786
In fact it could be interesting if I could integrate your module with mine, if you wish you may have a look at odir_image_colorbox and odir_image_lightbox2 ...

Looks Good, Tried the same and works cool !!!
I think the project is good to go from sandbox to project page :)

Cheers,
Rahul

Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.

You have a wrong-named branch in your repository "7.x.1.x"
Delete it with

git push origin :7.x.1.x
git branch -d 7.x.1.x

It would be nice to have more configurable display settings.

However, I didn't found anything serious, so

Thanks for your contribution and welcome to the community of project contributors on drupal.org!

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.