Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Apr 2012 at 14:15 UTC
Updated:
5 Dec 2012 at 21:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
kingbbq commentedThe integration with Roundcube is done via a roundcube plugin that is also part of the source.
this is the sample for PLESK with 50mb size of mailbox with Spamchecker and Virus-Checker on.
sudo /usr/local/psa/bin/mail -c $email -mailbox true -mbox_quota 50M -antivirus inout 2>&1;
sudo /usr/local/psa/bin/mail -u $email -passwd $password -mbox_quota 50M -antivirus inout 2>&1;
sudo /usr/local/psa/bin/spamassassin -u $email -status true -reject-spam true -hits 3 2>&1;
I will write detailed documentation on how to install in the next days...
Comment #2
patrickd commentedwelcome,
You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow tips for a great project page. Also create a README.txt that follows the guidelines for in-project documentation.
while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxkingbbq1536578git
We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.
regards
Comment #3
kingbbq commentedthanks patrick!
- I moved to a proper branch according to the documentation
- added readme.txt and documentation to the project page
- cleaned up errors from the automatic checking.
I will try to work on other reviews as recommended for the review bonus in the next days...
cheers
Gregor
Comment #4
patrickd commentedNote that the branch you've created does not follow naming rules for beeing able to create releases.
Please read the branch naming conventions.
Also note that you can re-run the automated review yourself on the "repeat review"-tab.
Comment #5
kingbbq commentedthanks, changed it to 7.x - I hope that is the right branch name now.
cheers
Gregor
Comment #6
patrickd commentedWell, now you created a core-named branch ;-)
drupal-7.x-dev.zip
myproject-7.x-1.x-dev.zip
myproject-7.x-2.x-dev.zip
Comment #7
kingbbq commentedg** damn it ;-)
Thanks for the hinting --> I am hoping for the best now :-)
Comment #8
luxpaparazzi commentedshouldn't the module-name refer to RoundCube?
it would also be nice giving a small introduction do whatever RoundCube is...
Comment #9
kingbbq commentedAll "normal" Module-Name like RoundCube or RoundCube Webmail are all already used (even though there is no more active project / no project for Drupal 7) so I choose this name. I provided a plugin for RoundCube, if other plugins for other webmails would be provided, the module would work also with others.
Comment #10
kingbbq commented...Added explanation of RoundCube and screenshots.
Comment #11
lukas.fischer commentedWhy don't you contact the the people who created http://drupal.org/project/rcmail or http://drupal.org/project/roundcube. I think it would make sense to work with existing projects. It's just my personal impression - What do others mean?
Comment #12
kingbbq commentedHi Lukas,
sure, why not. I'll contact them... you mean, using me module under the existing RoundCube Module, just as a new version?
cheers
Gregor
Comment #13
anwar_maxThere are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Manual Review:
1) Use proper indention and proper line spacing in your code.
2) In webmail3000_form() function you are using placeholders in t() function t('@domain_name used to generate emails')
but you are not passing values for it.
3) Write documentation for each function.
Comment #14
progger commentedI installed the "modul" It is good for the beginning. Thanks a lot. I saw that the login/logout, autologin, deletion, password change/update process is not working right now. Also the link version "click at webmail link to login roundcube" is sometimes not working correct with some browsers as the url is not correct somehow. I think anyway it would be better if the user has the chance to make a setting to login directly to roundcube intern area after drupal login.
Comment #15
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.