Closed (fixed)
Project:
Geocoder
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Apr 2012 at 17:21 UTC
Updated:
22 Jun 2012 at 23:11 UTC
I'm using this excellent module successfully, with the normal setup to get data from Addressfield, geocode it via Google and plug the data into Geofield. All is working fine except for a particular record which isn't entering any data - when I save it I get an error message Error geocoding - ZERO_RESULTS
The address looks fine, and when I use it within Google Maps it finds the location with no problems. I've tried putting the same address into another record, with the same results. Any suggestions please?
The address is: 801 West Georgia Street, Vancouver, British Columbia V6P 1C7, Canada
Comments
Comment #1
phayes commentedI've seen a similar problem. I think perhaps we should remove the postal code from the address field when we collapse all the components for sending off to a geocoding handler.
Comment #2
phayes commentedOkay, I've just committed a change that removes the postal code. Can you test please?
Comment #3
adam_b commentedSorry but I'm not a developer so I don't know how to get hold of your change. Could you supply me with a zipped version of the module with the change? or at least a patch? Thanks.
Comment #4
adam_b commentedYou're right that it does appear to be a postcode issue:
- Saving the address without the postcode works fine
- Google gives V6C 3G1 as the postcode for that generic address, and saving the address with this postcode works fine - but Canada Post says this postcode is wrong - it's for 885 West Georgia, not 801
- Google gives V6P 1C7 for the hotel & restaurant at that address, and Canada Post confirms this is the correct postcode for that whole address
So I'm guessing that it's a Google error... in which case I'm not sure what can be done about it.
It would be nice if the interface allowed an editor to manually override the geofield information in case of error or inaccuracy - is this possible?
In principle, I'm not crazy about removing the postal code as a matter of course, because sometimes it can be a crucial element to find a location, eg in rural areas.
Comment #5
adam_b commentedAnother example of the same problem - address is:
Hotel Relais Saint Germain
9 Carrefour de l’Odéon
75006 Paris
France
Comment #6
phayes commentedYou can download the 7.x-1.x-dev tarball on the project page.
Marking as fixed. Please reopen if you have problems
Comment #8
adam_b commentedOkay... removing the postcode from the verification is causing problems as I suspected, and not even in rural areas.
When trying to get the location for "10 Northumberland Avenue, London WC2N 5AE" which is in the centre of the city, I'm given a location in the far east end of London. There's a Northumberland Avenue there also with postcode E12 5H5, and I'm guessing it comes first in the list.
I've reverted to v7-1.0 and I guess I'll have to manually correct any that I find which aren't processed by Google.
Comment #9
steinmb commented+1 for a rollback. Omitting the postal code is causing problems for us too. Was the original problem 'only' for certain addresses in Canada decoded with Google?
Comment #10
adam_b commentedNot only in Canada (see comment #5 above) but with Google, yes.
Comment #11
steinmb commentedAh, sorry missed that one.
Is http://maps.googleapis.com/maps/api/geocode/json?sensor=false&address=Ho... still giving your the wrong position then?
Comment #12
phayes commentedOK, we're going to roll this back
Comment #13
henryblyth commentedThanks @phayes. I'm working very closely with Geocoder right now, and utilising the postcode will be fantastic.
In #1 you mentioned coming across this problem before. Would you mind detailing the issues you have had, for the education of all?
Thanks @adam_b in #8 for giving an example in the UK so I can test it. For that one in particular, putting Westminster in Address 2 finds the correct location. However, I can see users omitting that line, thinking that the postcode will precisely identify the location.
So looking forward to a roll back! Thanks again @phayes =D
Henry
Comment #14
phayes commentedAlrighty, it's been reverted.