Closed (fixed)
Project:
Rules
Version:
7.x-2.x-dev
Component:
Project Maintenance
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Apr 2012 at 23:50 UTC
Updated:
10 Apr 2013 at 13:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
mitchell commentedAdded redirect test to the issue summary.
Marked #1797576: Fix simpletest tests as a duplicate.
Comment #2
PatchRanger commentedSimpletest tests on localhost passed.
It seems to me that the reason is (as I've mentioned in #1651132: RulesI18nStringObjectWrapper needs an $object_key parameter : https://drupal.org/node/1651132#comment-6533670) in the necessity of branch retesting. I mean one of the Rules maintainers has to force retesting of the whole branch.
@Rules maintainers: Please force branch retesting. There is no other way to fix this problem since all tests seem to be ok.
Comment #3
mitchell commented> Simpletest tests on localhost passed.
That's really weird. The 'email a role' and 'redirect' tests both aren't passing for me. Everything else is okay.
> Please force branch retesting.
I performed a re-test @ http://qa.drupal.org/pifr/test/27274 , and it shows the same output as before.
Comment #4
PatchRanger commentedOk, I will give it one more try. Thanks for your time.
Comment #5
PatchRanger commentedI have most of the tests passed again.
I have understood the reason of this weird behavior: the difference between Rules code and mine is in the patch I've posted earlier: #1797898: Make RulesCondionInterface and RulesActionInterface to match classes that implement them.
Please review that patch. It solves part of the problem. Now I have only one problem: testPHPIntegration failed. I need more time to look into it.
Comment #6
fago> Simpletest tests on localhost passed.
That's really weird. The 'email a role' and 'redirect' tests both aren't passing for me. Everything else is okay.
That's strange. For me they are all working?
FYI: This are the module versions the bot uses:
Comment #7
mitchell commentedComment #8
PatchRanger commentedAs you could see at http://qa.drupal.org/pifr/test/27274 RulesI18nTestCase is failed.
I've split out the i18n test case into small classes on my local site to determine which one is broken indeed.
Ha, they all failed.
I think the problem is in dependency module: i18n_string.
You could find reports of launching them splitted attached.
I continue debugging.
Comment #9
PatchRanger commentedThough all tests passed if run via Simpletest admin UI (see screenshots attached).
The problem is definitely in the process of installation.
I shall try to turn off all Rules-related modules - and run Simpletest-tests through admin UI again to get the same errors as with cli. Also I am going to re-run tests via cli with --verbose option.
Comment #10
PatchRanger commentedPlease consider #8 as incorrect: I've done testing wrong (didn't assign root url).
After doing it all right, I got finally all tests passed - yay! Proof is attached.
I have the latest 7.x-2.x version of Rules patched with the following patches:
Please review all of them as soon as possible!
This patch is part of the #1day1patch initiative.
Comment #11
PatchRanger commentedI have forgotten to change the status.
Comment #12
fagoTests should already work as they are now - please re-open if not.
Comment #13.0
(not verified) commentedUpdated