Comments

mitchell’s picture

Title: Tests: 'mail_to_users_of_role' is broken » Fix broken simpletests
Priority: Normal » Major

Added redirect test to the issue summary.
Marked #1797576: Fix simpletest tests as a duplicate.

PatchRanger’s picture

Simpletest tests on localhost passed.
It seems to me that the reason is (as I've mentioned in #1651132: RulesI18nStringObjectWrapper needs an $object_key parameter : https://drupal.org/node/1651132#comment-6533670) in the necessity of branch retesting. I mean one of the Rules maintainers has to force retesting of the whole branch.
@Rules maintainers: Please force branch retesting. There is no other way to fix this problem since all tests seem to be ok.

mitchell’s picture

> Simpletest tests on localhost passed.
That's really weird. The 'email a role' and 'redirect' tests both aren't passing for me. Everything else is okay.

> Please force branch retesting.
I performed a re-test @ http://qa.drupal.org/pifr/test/27274 , and it shows the same output as before.

PatchRanger’s picture

The 'email a role' and 'redirect' tests both aren't passing for me. Everything else is okay.

Ok, I will give it one more try. Thanks for your time.

PatchRanger’s picture

I have most of the tests passed again.
I have understood the reason of this weird behavior: the difference between Rules code and mine is in the patch I've posted earlier: #1797898: Make RulesCondionInterface and RulesActionInterface to match classes that implement them.
Please review that patch. It solves part of the problem. Now I have only one problem: testPHPIntegration failed. I need more time to look into it.

fago’s picture

> Simpletest tests on localhost passed.
That's really weird. The 'email a role' and 'redirect' tests both aren't passing for me. Everything else is okay.

That's strange. For me they are all working?

FYI: This are the module versions the bot uses:

  'vcs' => array(
    'main' => array(
      'repository' => array(
        'type' => 'git',
        'url' => 'git://git.drupal.org/project/rules.git',
      ),
      'vcs_identifier' => '7.x-2.x',
    ),
    'dependencies' => array(
      0 => array(
        'repository' => array(
          'type' => 'git',
          'url' => 'git://git.drupal.org/project/drupal.git',
        ),
        'vcs_identifier' => '7.x',
      ),
      1 => array(
        'repository' => array(
          'type' => 'git',
          'url' => 'git://git.drupal.org/project/entity.git',
        ),
        'vcs_identifier' => '7.x-1.0-rc3',
      ),
      2 => array(
        'repository' => array(
          'type' => 'git',
          'url' => 'git://git.drupal.org/project/i18n.git',
        ),
        'vcs_identifier' => '7.x-1.5',
      ),
      3 => array(
        'repository' => array(
          'type' => 'git',
          'url' => 'git://git.drupal.org/project/variable.git',
        ),
        'vcs_identifier' => '7.x-2.0-beta1',
mitchell’s picture

Component: Rules Core » Project Maintenance
PatchRanger’s picture

StatusFileSize
new334 bytes
new314 bytes
new300 bytes

As you could see at http://qa.drupal.org/pifr/test/27274 RulesI18nTestCase is failed.
I've split out the i18n test case into small classes on my local site to determine which one is broken indeed.
Ha, they all failed.
I think the problem is in dependency module: i18n_string.
You could find reports of launching them splitted attached.
I continue debugging.

PatchRanger’s picture

Though all tests passed if run via Simpletest admin UI (see screenshots attached).
The problem is definitely in the process of installation.
I shall try to turn off all Rules-related modules - and run Simpletest-tests through admin UI again to get the same errors as with cli. Also I am going to re-run tests via cli with --verbose option.

PatchRanger’s picture

Status: Needs review » Active
StatusFileSize
new2.79 KB
new3.29 KB
new16.15 KB
new1.09 KB
new14.58 KB
new8.73 KB
new2.44 KB

Please consider #8 as incorrect: I've done testing wrong (didn't assign root url).
After doing it all right, I got finally all tests passed - yay! Proof is attached.
I have the latest 7.x-2.x version of Rules patched with the following patches:

Please review all of them as soon as possible!

This patch is part of the #1day1patch initiative.

PatchRanger’s picture

Status: Active » Needs review

I have forgotten to change the status.

fago’s picture

Status: Active » Fixed

Tests should already work as they are now - please re-open if not.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated