Hello,
I have had no reply to my post a month ago about joining forces on a single chess module (http://drupal.org/node/1413252#comment-5751050), and I don't see any activity on this module, for example, to move to Drupal 7 (the last commit was over 1 year ago), so more and more I have the feeling that it looks like you folks are no longer moving this module on. Which is fine, but since I am active in the development of the VChess module I would like to also become a maintainer of the Chess module. So please let me know if I could become joint maintainer (of if you really are not going to work any longer on it, then sole maintainer).
Thanks!
P.S. I am following the procedure for dealing with unsupported projects.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | chess-7.x-1.x-dev.zip | 217.9 KB | drupalshrek |
Comments
Comment #1
eric_a commentedHave you started working on Chess D7 code? Please provide your thoughts and code to the community for discussion in the issue queue.
I'm mostly interested in a straightforward upgrade. No functional changes and a clean upgrade path from Chess 6.x-1.0.
Joining forces in the community is also about participating in existing issues, especially if you're seeking to (co-)maintain. Sure, the procedure for dealing with unsupported projects is an important one; but so is the one for applying as co-maintainer: http://drupal.org/node/363367.
Comment #2
drupalshrek commentedHello Eric_A,
Thanks for getting back to me.
My aim is simply to have a single chess module on Drupal. I am not looking to be a maintainer of both the VChess and Chess modules. Since I had no reaction from my other request (http://drupal.org/node/1413252#comment-5751050), I thought I would just try and take over what looked like maybe an abandoned module, and simply do a merge of the two modules myself.
Is this something you are interested in?
At the start of this year, I wanted to have a great Drupal chess module, so had a look at what was available. I compared in reasonable detail VChess and Chess. Both of them do a lot of the basics fine, e.g.:
The Chess module has some things which VChess did not have which were interesting, e.g. the Outstanding Chess Moves block, the Random Chess game block, and use of a custom-node type for games.
Ultimately though I had to make a choice, and I thought that VChess had a much better user interface: rather than using drop-downs where the user chooses source square first with a-h then 1-8 and then the destination square first with a-h then 1-8, VChess has a mouse-controlled point-and-click interface.
Since then I have done a lot of work on VChess, adding things which were in neither module previously, e.g.:
Are you interested in having a single chess module? If so, I will outline how I would propose to do it (which would include of course shutting down VChess and providing Chess users a clean upgrade path from Chess 6.x-1.0).
Comment #3
eric_a commented@drupalshrek: my guess is that converting your VChess code to the Chess namespace gives us a look at a future Chess 7.x-2.x. Here I am mainly interested in reviewing and testing a patch that gives us straight upgrade to Chess 7.x-1.x. Straight as in the smallest possible change, breaking as little as possible for the 40-60 something users. When that is done, a change to 7.x-2.x would become reviewable. When there's some code to review and test, then people can really see what they could be having.
@Tim_O, @EoinBailey, @drupalshrek: I'm interested in the idea of having a Drupal chess framework or protocol that handles stuff like libraries (css, js, images), Chess GUI projects, and Chess Engine projects. Mainly to ease maintaining these components. Secondly because there's nothing wrong with having multiple GUI's and engines available as long as there are distinct feature sets/ requirements/ dependencies. But that is to be discussed elsewhere.
Comment #4
drupalshrek commentedHi Eric_A,
OK, I have begun work on a straight upgrade with the minimum changes possible for a 7.x-1.x version, based solely on the existing chess 6 module, and progress is already not bad: module install now works, help works, blocks work. Nonetheless, I already see that it is going to be quite a lot of work, so it's rather more a dev branch than a patch (though of course a patch can be technically as big as anything), so I would like to check it in to a 7.x-1.x-dev branch as I progress. To be able to do that I would like to be given co-maintainer access.
Comment #5
eric_a commentedIt's good practice to have project code reviewed and tested by the community *before* it makes it into any official development branch. Just post full (ZIP) archives and I'll help rolling patches. If you don't agree with any of the points made in http://drupal.org/node/363367, just say so and we'll agree to disagree.
On a side note: save yourself the work of converting the simple static SELECT queries into the shiny new OO DBTNG-layer. The D7 db_query() function will do just fine when queries need not be alterable.
Comment #6
drupalshrek commentedHi Eric_A,
Ha, ha, I can see it's going to be fun if we work on the same module together!
Please find attached a ZIP of the partially complete vanilla transition of the current 6.x-1.x-dev code to D7. You will see there are a couple of functions commented out completely because they currently give errors. This code is definitely not D7 ready, but it has some of the transition work done, in particular the following work:
I was most recently stuck on getting the "white_player" and "black_player" names as part of the node type being passed.
I am no longer going to work on this task. I think it would be ideal if you (or someone else) were to complete this 7.x-1.x version. But I don't want to. That's the great thing about open-source, I can pick and choose the things I want to work on! And helping those on 6.x-1.x migrate is not something I care to work on any more, but if you or someone else wants to, great. I hope what I have done already will be of some help.
You said earlier "When that [the creation of a 7.x-1.x branch] is done, a change to 7.x-2.x would become reviewable". I actually think the 7.x-2.x branch can develop in parallel; I would still like to offer therefore to adapt the VChess module to be a 7.x-2.x branch.
My reasoning is as follows. There are 3 types of users which I can think of:
For 1.1 the work on the ZIP I have just added needs to be completed. I am not interested in doing that work.
For 1.2 there would need to be additional work to convert the database tables; the 7.x-2.x branch would use a very different structure (more or less the structure currently seen in VChess). I am not interested in doing that work.
For 2 and 3 there would only need to be a conversion of the VChess module to the Chess namespace. I am OK to do that.
It would be a lot easier for me to work without you on the VChess module, but I am trying to avoid the modules with duplicate functionality as in Joining forces with others and co-maintaining projects.
It seems to me that there are various routes you can choose:
If you don't want me to develop yet a 7.x-2.x branch, then I will just keep developing within the VChess module.
Comment #7
drupalshrek commentedP.S. I notice Eric that you have never apparently committed anything to the Chess module. What's your connection to it?
Comment #8
eric_a commentedMy connection to the Chess project is easily traceable when searching the Chess issue queue.
Your ZIP from #6 is converted to a patch in #1551864: Port Chess to Drupal 7.
If you post a ZIP of VChess converted to a chess-7.x-2.x-dev I can help out by converting it to a patch that can be reviewed and tested by the Chess community. Ultimately the contrib project maintainers and d.o. webmasters judge efforts and decide on what happens with patches and projects.
Comment #9
drupalshrek commentedOK, I get it now: you're not one of maintainers of the Chess project at all! You're the maintainer of the chessboard module and want to try and get the Chess module to use your module.
Gosh, and I thought I was talking to the right person to let me in and maintain this module!
OK, well, I think it's clear now.
And still not the slightest comment from any of the maintainers of the module.
Comment #10
eric_a commentedIn #1 and #5 I referred to the contents of the "Best practices for co-maintaining projects" page. I'm assuming the section "Applying as co-maintainer" was not to your liking or you just interpret it differently.
OK, I get it now: you're not one of maintainers of the Chess project at all!
I'm assuming you're just not used to the way the Drupal community joins in in many of the contributed projects on d.o.
Contributing is what really matters in the issue queues, whether it is reviewing, testing, reporting or submitting code.
I hope that @Tim_O or @EoinBailey will quickly find the time to review your effort in #1551864: Port Chess to Drupal 7. (But maybe they will leave that to the community and just commit code from issues that are RTBC, as many maintainers do.)
Comment #11
drupalshrek commentedIf none of the maintainers respond soon to my request to become maintainer, I will request from d.o. to become maintainer directly.
Comment #12
EoinBailey commentedHi DrupalShrek,
After being away from this for quite some time, I will be returning to the module in the near future (I'm submitting my PhD in the coming weeks). If you wish to be a maintainer of this project, as Eric_A as pointed out it would be best if you work on issues in the queue and continue to submit patches for these issues.
- Eoin
Comment #13
drupalshrek commentedHi Eoin,
As I tried to explain to Eric_A, I am not interested in maintaining both VChess and the Chess module: I would like to merge the two modules, and unless you're interested in that, I'll just stick on with improving VChess.
drupalshrek
Comment #14
drupalshrek commentedHi,
You can now actually try out the VChess module in the working chess website Chesspos.com!
Enjoy!
drupalshrek
Comment #15
Leeteq commentedA merge sounds interesting.
I can think of a number of features that would be specific to displaying parts of the information related to chess games, in blocks, views, etc., potentially with some specific code that is needed in addition to what the blocks and views system already provides.
Not sure if it is enough to keep two modules, but here is a thought:
From: #331971: Merge with the Chessboard module?.
Comment #16
avpadernoI am closing this issue as it's for a Drupal version that isn't supported.