I enabled feedback (http://drupal.org/project/feedback)

I do not wan the meta tags field set to show up. It adds a lot of overhead in this situation.

is there a way for me to disable it for that feature?

Comments

dman’s picture

Title: Is there a way to exclude from a page or entity? » Is there a way to exclude from a page or entity? (Conflict with 'feedback' module) (fix found)
Status: Active » Needs review
StatusFileSize
new278 bytes
new18.6 KB

Ditto. The 'Feedback' module manages its content as an 'entity' - although those entities do not have any public face.

Metatags has gone and inserted itself into the mini feedback form, and there seems to be no way to stop that from happening.

Looking at how this gets in there, (metatag_field_attach_form ?) Looks like the call to metatag_entity_supports_metatags() might be the place that can be disabled?

    // By default allow entities that have fields and have paths.
        $entity_info['metatags'] = !empty($entity_info['uri callback']) && !empty($entity_info['fieldable']);

'feedback' entries *do* have a URI callback - but that's internal only, used for reporting. And, for whatever reason, feeedback submissions are also fieldable.

*IT APPEARS* that it's possible for feedback to ask NOT to have metatags. Patching feedback_entity_info() should do that?
Is there a place that API is documented?

Here be a patch AGAINST FEEDBACK.module that stops metatags from messing with it.

@@ -64,6 +64,7 @@ function feedback_entity_info() {
           'custom settings' => FALSE,
         ),
       ),
+      'metatags' => FALSE,
     ),
   );

It's a philosophical decision about whether entity providers should have to opt-in-or opt-out of metatags support and whose job this is- though I appreciate that metatags did a pretty good job of trying to guess. :-}
Given that there IS this metatags flag, and it DOES work, I guess this can be shunted to feedback to deal with.

Project admins - please just note that this did cause an issue for third party modules, add a note to the docs or something, and then push this issue to feedback to deal with and commit over there.

Status: Needs review » Needs work

The last submitted patch, metatag_vs_feedback-1543900.patch, failed testing.

dman’s picture

Yeah sorry testbot, it's against a different module. Did you not read my explanation? :-)

NecroHill’s picture

dman: this patch does not work for me, I have applied this to the latest dev version but meta tags fieldset still appears
sorry, it does work, the fieldset disappeared when I add a new field to the form

dman’s picture

Project: Metatag » Feedback
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Needs review

Shunting to feedback module to apply as a work-around if metatags won't be changed to be more configurable for now.
This patch is to feedback, so I guess we test it there.

socialnicheguru’s picture

patch did work for me.

A feature request would be to have an admin page where you could specify which entities you would like metatags on.
Otherwise it's best for me to place changes it in a custom module.

damienmckenna’s picture

Status: Needs review » Reviewed & tested by the community

The patch in #1 is the correct way of handling this request.

sun’s picture

Status: Reviewed & tested by the community » Fixed

Added a comment.

Thanks for reporting, reviewing, and testing! Committed to 7.x-2.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.