Closed (fixed)
Project:
Feedback
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2012 at 20:59 UTC
Updated:
4 Nov 2012 at 17:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
dman commentedDitto. The 'Feedback' module manages its content as an 'entity' - although those entities do not have any public face.
Metatags has gone and inserted itself into the mini feedback form, and there seems to be no way to stop that from happening.

Looking at how this gets in there, (metatag_field_attach_form ?) Looks like the call to metatag_entity_supports_metatags() might be the place that can be disabled?
'feedback' entries *do* have a URI callback - but that's internal only, used for reporting. And, for whatever reason, feeedback submissions are also fieldable.
*IT APPEARS* that it's possible for feedback to ask NOT to have metatags. Patching feedback_entity_info() should do that?
Is there a place that API is documented?
Here be a patch AGAINST FEEDBACK.module that stops metatags from messing with it.
It's a philosophical decision about whether entity providers should have to opt-in-or opt-out of metatags support and whose job this is- though I appreciate that metatags did a pretty good job of trying to guess. :-}
Given that there IS this metatags flag, and it DOES work, I guess this can be shunted to feedback to deal with.
Project admins - please just note that this did cause an issue for third party modules, add a note to the docs or something, and then push this issue to feedback to deal with and commit over there.
Comment #3
dman commentedYeah sorry testbot, it's against a different module. Did you not read my explanation? :-)
Comment #4
NecroHill commenteddman:
this patch does not work for me, I have applied this to the latest dev version but meta tags fieldset still appearssorry, it does work, the fieldset disappeared when I add a new field to the form
Comment #5
dman commentedShunting to feedback module to apply as a work-around if metatags won't be changed to be more configurable for now.
This patch is to feedback, so I guess we test it there.
Comment #6
socialnicheguru commentedpatch did work for me.
A feature request would be to have an admin page where you could specify which entities you would like metatags on.
Otherwise it's best for me to place changes it in a custom module.
Comment #7
damienmckennaThe patch in #1 is the correct way of handling this request.
Comment #8
sunAdded a comment.
Thanks for reporting, reviewing, and testing! Committed to 7.x-2.x.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.